Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-117753 [Content Dashboard] Filter by tag #60

Closed
wants to merge 7 commits into from

Conversation

cgoncas
Copy link
Collaborator

@cgoncas cgoncas commented Jul 23, 2020

Motivation

The categorization and tagging of content is one of the most important metadata for its exploitation by different areas of the organization and its possible reuse. Being able to filter by categories, not only those visible at the first level (selected in Configuration if the audit graph)) but also by the rest of them, speeds up the searches and the auditing of the content.

Provided Solution

We have added an item selector in the Content Dashboard filter and implement the search by asset tags in ES.

How to test it

  1. Create a Web Content
  2. Add a Tag to the Web Content
  3. Go to Global App Menu > Content Dashboard
  4. Click Filter By > Tags ...
  5. Select the tag added to the Web Content in step 2.
  6. The content created in step 2 should be shown.

Filter By Tags

@liferay-continuous-integration

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:test:sf

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:test:relevant

@cgoncas cgoncas changed the title LPS-117753 Add test. LPS-117753 Filter by Asset Ccategories. Jul 23, 2020
@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

Hey @dgarciasarai and @darquesdev!!

Could you take a look to this pull :)

Thanks!

@liferay-continuous-integration

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 594eb9ea7ba79fcfb46cf33c92c77e34d592db0b

Sender Branch:

Branch Name: LPS-117753
Branch GIT ID: a4d80755685ca8ee6dd4a48b04f097cb2fdce89e

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: Truncated message :
     [java] ./modules/apps/content-dashboard/content-dashboard-test/src/testIntegration/java/com/liferay/content/dashboard/web/internal/portlet/test/ContentDashboardAdminPortletTest.java expected:<...tSearchContainerWith[ContentDashboardItemType()
     [java] 		throws Exception \{
     [java] 
     [java] 		DDMStructure ddmStructure = DDMStructureTestUtil.addStructure(
     [java] 			_group.getGroupId(), JournalArticle.class.getName(), 0,
     [java] 			DDMStructureTestUtil.getSampleDDMForm(),
     [java] 			LocaleUtil.getSiteDefault(),
     [java] 			ServiceContextTestUtil.getServiceContext());
     [java] 
     [java] 		DDMTemplate ddmTemplate = DDMTemplateTestUtil.addTemplate(
     [java] 			_group.getGroupId(), ddmStructure.getStructureId(),
     [java] 			PortalUtil.getClassNameId(JournalArticle.class),
     [java] 			TemplateConstants.LANG_TYPE_VM,
     [java] 			JournalTestUtil.getSampleTemplateXSL(),
     [java] 			LocaleUtil.getSiteDefault());
     [java] 
     [java] 		ServiceContext serviceContext =
     [java] 			ServiceContextTestUtil.getServiceContext(
     [java] 				_company.getCompanyId(), _group.getGroupId(),
     [java] 				_user.getUserId());
     [java] 
     [java] 		JournalArticle journalArticle =
     [java] 			JournalTestUtil.addArticleWithXMLContent(
     [java] 				JournalFolderConstants.DEFAULT_PARENT_FOLDER_ID,
     [java] 				JournalArticleConstants.CLASS_NAME_ID_DEFAULT, 0,
     [java] 				DDMStructureTestUtil.getSampleStructuredContent(),
     [java] 				ddmStructure.getStructureKey(), ddmTemplate.getTemplateKey(),
     [java] 				LocaleUtil.getSiteDefault(), null, serviceContext);
     [java] 
     [java] 		JournalTestUtil.addArticle(_user.getUserId(), _group.getGroupId(), 0);
     [java] 
     [java] 		MockLiferayPortletRenderRequest mockLiferayPortletRenderRequest =
     [java] 			_getMockLiferayPortletRenderRequest();
     [java] 
     [java] 		mockLiferayPortletRenderRequest.setParameter(
     [java] 			"contentDashboardItemTypePayload",
     [java] 			JSONUtil.put(
     [java] 				"className", DDMStructure.class.getName()
     [java] 			).put(
     [java] 				"classPK", ddmStructure.getStructureId()
     [java] 			).toString());
     [java] 
     [java] 		SearchContainer<Object> searchContainer = _getSearchContainer(
     [java] 			mockLiferayPortletRenderRequest);
     [java] 

@cgoncas cgoncas changed the title LPS-117753 Filter by Asset Ccategories. LPS-117753 Filter by Asset Categories. Jul 23, 2020
@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:stop

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:test:stop

@liferay-continuous-integration

Jenkins Build:test-portal-source-format#4292
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#60
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#60 - 2020-07-23[03:25:16]
Spira Jenkins Build:publish-spira-report#4387

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:test:sf

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 23, 2020

ci:test:relevant

@cgoncas cgoncas changed the title LPS-117753 Filter by Asset Categories. LPS-117753 Filter by Tags. Jul 23, 2020
@liferay-continuous-integration

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4d667230e673a0ba7f0b09b45a43282655cae6b3

Sender Branch:

Branch Name: LPS-117753
Branch GIT ID: 639139e625376c47c31d091a5ea325b935a6643a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration

Jenkins Build:test-portal-source-format#3465
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#60
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#60 - 2020-07-23[03:31:43]
Spira Jenkins Build:publish-spira-report#1219

@liferay-continuous-integration

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff793ccc3264526c4bf0e6d329149bc1204096d7

Sender Branch:

Branch Name: LPS-117753
Branch GIT ID: e6e3bd56baabf2a4061e2976f43d36af95731cb5

0 out of 1jobs PASSED
For more details click here.
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:160)
[stopwatch] [run.batch.test.action: 59.680 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:567: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:707: Java returned: 1
      [get] Getting: http://test-1-11/job/test-portal-source-format/4300//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20200727050320107.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20200727050320107.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1629133878.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null819104824
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 228ms
[junitreport] Deleting: /tmp/null819104824
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results
[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results
[echo] run.batch.test.tear.down.start.timestamp: 07-27-2020 05:03:24:709 PDT
[stopwatch] [run.batch.test.tear.down: 0.000 sec]
[echo]
[echo] Ant GC log:
[echo]
[echo] Java HotSpot(TM) 64-Bit Server VM (25.121-b13) for linux-amd64 JRE (1.8.0_121-b13), built on Dec 12 2016 16:36:53 by "java_re" with gcc 4.3.0 20080428 (Red Hat 4.3.0-8)
[echo] Memory: 4k page, physical 32902076k(421588k free), swap 0k(0k free)

@liferay-continuous-integration

Jenkins Build:test-portal-source-format#4300
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#60
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#60 - 2020-07-27[05:01:01]
Spira Jenkins Build:publish-spira-report#1462

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 27, 2020

cci:tetst:sf

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 27, 2020

ci:test:sf

@liferay-continuous-integration

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff793ccc3264526c4bf0e6d329149bc1204096d7

Sender Branch:

Branch Name: LPS-117753
Branch GIT ID: e6e3bd56baabf2a4061e2976f43d36af95731cb5

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration

Jenkins Build:test-portal-source-format#3676
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#60
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#60 - 2020-07-27[06:23:41]
Spira Jenkins Build:publish-spira-report#1502

@liferay-continuous-integration

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 43 out of 43 jobs passed in 2 hours 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b80de97bb706d0d3864d9e15bc43d469aa0f8e41

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2aa558d7587a046d654b60e91d9b21cb5e106df3

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 43 out of 43 jobs PASSED
43 Successful Jobs:
For more details click here.

@liferay-continuous-integration

@cgoncas
Copy link
Collaborator Author

cgoncas commented Jul 27, 2020

ci:forward

@liferay-continuous-integration

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration

Pull request has been successfully forwarded to brianchandotcom#91852

@liferay-continuous-integration

Jenkins Build:test-portal-source-format#4069
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#60
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#60 - 2020-07-27[01:49:10]
Spira Jenkins Build:publish-spira-report#4521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants