Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-140986 Add new junction by description #583

Closed
wants to merge 2 commits into from
Closed

LPS-140986 Add new junction by description #583

wants to merge 2 commits into from

Conversation

seltong
Copy link

@seltong seltong commented Oct 26, 2021

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@seltong
Copy link
Author

seltong commented Oct 26, 2021

ci:test:sf

@seltong
Copy link
Author

seltong commented Oct 26, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4713e52108fc28718010c732d2c070ac1602b12e

Sender Branch:

Branch Name: LPS-140986
Branch GIT ID: 835fbebc2c405de5275924fac61b38a1eb4c0042

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4713e52108fc28718010c732d2c070ac1602b12e

Sender Branch:

Branch Name: LPS-140986
Branch GIT ID: 835fbebc2c405de5275924fac61b38a1eb4c0042

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 27 out of 28 jobs passed in 2 hours

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4713e52108fc28718010c732d2c070ac1602b12e

Upstream Comparison:

Branch GIT ID: 4713e52108fc28718010c732d2c070ac1602b12e
Jenkins Build URL: Acceptance Upstream DXP (master) #2497

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 26 out of 28 jobs PASSED
26 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 4713e52:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0 #10774
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1635283049970.log:
!SESSION 2021-10-26 21:17:41.947 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.site.initializer.extender 4 0 2021-10-26 21:17:41.948
        
!MESSAGE FrameworkEvent ERROR
        
!STACK 0
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [367]
        
Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)


at com.lifer...</code></pre></div></li><li><div><a href="https://test-1-27.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/10774//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 

        

        FrameworkEvent ERROR
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [367]
        
Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.asser...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>

@liferay-continuous-integration
Copy link
Collaborator

rafaprax
rafaprax requested changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@rafaprax rafaprax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @seltong, Could you please add an integration test to cover this change? Thx

@seltong seltong requested a review from rafaprax October 28, 2021 15:51
@seltong
Copy link
Author

seltong commented Oct 28, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2315af84ed4c81406da2595e5c446e23f7288fa3

Sender Branch:

Branch Name: LPS-140986
Branch GIT ID: 5aa50ef198b90a78c0ee0586060c7e6e9a0b037f

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@rafaprax
Copy link
Collaborator

Just started reviewing :)

2 similar comments
@rafaprax
Copy link
Collaborator

Just started reviewing :)

@rafaprax
Copy link
Collaborator

Just started reviewing :)

@rafaprax
Copy link
Collaborator

resent #591

@rafaprax rafaprax closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarinhoFeliphe MarinhoFeliphe Awaiting requested review from MarinhoFeliphe

@rafaprax rafaprax Awaiting requested review from rafaprax

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seltong @liferay-continuous-integration @rafaprax