Skip to content

/ alloy-editor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert email addresses into mailto: links #522

Closed
mattleff opened this issue May 18, 2016 · 1 comment
Closed

Convert email addresses into mailto: links #522

mattleff opened this issue May 18, 2016 · 1 comment
Labels
feature
Milestone
1.2.1

Comments

@mattleff
Copy link
Contributor

@mattleff mattleff commented May 18, 2016 •
edited

In the link dialog when you enter me@example.com it would make more sense to link it as mailto:me@example.com instead of http://me@example.com. The link dialog should be smart enough to convert medium.com/@wob/the-sad-state-of-web-development-1603a861d29f to http://medium.com/@wob/the-sad-state-of-web-development-1603a861d29f though.

Pull: #523.
@ipeychev ipeychev added this to the 1.2.1 milestone May 23, 2016
@ipeychev ipeychev added the feature label May 23, 2016
@ipeychev
Copy link
Contributor

@ipeychev ipeychev commented May 23, 2016

Hey @mattleff,

Thanks for the contribution. There are some comments on the pull request, would you like to take a look on them?

Thanks,
mattleff added a commit to SimpleUpdates/alloy-editor that referenced this issue May 23, 2016
@mattleff
Fixes liferay#522
feb4063
@ipeychev ipeychev closed this in 04e05a9 May 23, 2016
ipeychev added a commit that referenced this issue May 23, 2016
@ipeychev
Update the regex for detecting an email address
ea17b49 
Fixes #522
ipeychev added a commit that referenced this issue May 23, 2016
@ipeychev
Add build files (auto-generated)
Loading status checks…
23028b8 
Fixes #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.2.1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ipeychev @mattleff