Don't use process.env.PWD in build #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on Windows is not officially supported, but we can easily remove one issue on that platform by removing our use of the PWD environment variable, which won't be set on Windows. I can't remember why I did it this way, but I am guessing it was to avoid the ugliness of the "../../../..". Test plan: add a `console.log` statement to sanity check the constructed path and do `npm run build`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Windows is not officially supported, but we can easily remove one issue on that platform by removing our use of the
PWDenvironment variable, which won't be set on Windows.I can't remember why I did it this way, but I am guessing it was to avoid the ugliness of the "../../../..".
Test plan: add a
console.logstatement to sanity check the constructed path and donpm run build.