fix: gracefully handle invalid JSON in data-style attribute (#1393)

[georgel-pop-lr]

Is fixing #1393 If data-style attribute is not a valid JSON an exception will be thrown and the code will stop working.

[wincent]

Thanks @georgel-pop-lr. Can you please run yarn format on this (that's what CI is complaining about) and do a git commit --amend and force push to update this with a new title (both the commit subject line and the PR title need to start with "fix: " otherwise the semantic PR bot will complain (not sure why it hasn't yet). You could use a subject/title like this:

fix: gracefully handle invalid JSON in data-style attribute (#1393)

[georgel-pop-lr]

Thanks @georgel-pop-lr. Can you please run yarn format on this (that's what CI is complaining about) and do a git commit --amend and force push to update this with a new title (both the commit subject line and the PR title need to start with "fix: " otherwise the semantic PR bot will complain (not sure why it hasn't yet). You could use a subject/title like this:

fix: gracefully handle invalid JSON in data-style attribute (#1393)

Thanks @wincent, hope is fine now.

[wincent]

Couple things here:

1. Linter may warn about unused variable e here, so either use it (in the log statement) or mark it as intentionally unused by starting it with an underscore (ie. _error). Note also that we try to avoid abbreviations if we can (ie. prefer error over e), except for things like i for loop variables.
2. We generally try to avoid anything that might resemble console spew in Liferay projects because it can be hard for customers to distinguish between bugs and mere diagnostic information (see guidelines on this); sometimes they see console output as a sign of bugginess and any "helpful" output we might include actually just confuses them. And they may be alarmed to see a message ending in an exclamation point. As such, I'd actually just swallow this error rather than log it — in some browsers, the stack trace that comes with console.warn looks particularly scary.

[wincent]

lg2m