Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reset uibridge definitions each time we destroy and create and editor (#1537) #1538

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix: Reset uibridge definitions each time we destroy and create and editor (#1537) #1538

merged 1 commit into from
Aug 31, 2022

Conversation

georgel-pop-lr
Copy link
Member

fix: Reset uibridge definitions each time we destroy and create and editor (#1537)

We can use https://issues.liferay.com/browse/LPS-156925 to upgrade alloy-editor version in the portal.

diegonvs
diegonvs approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@diegonvs diegonvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like unit tests are not being executed, but I took your PR and run unit tests, and everything looks okay. Also, testing manually, I can't see anything broken. So, LGTM

@diegonvs diegonvs merged commit 23d8609 into liferay:master Aug 31, 2022
@diegonvs diegonvs mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegonvs diegonvs diegonvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgel-pop-lr @diegonvs