fix: Calculate the offsetHeight for the toolbar only when the table is used

[orsolyaDekany]

Hi Team,

Issue: #1542
LPS: https://issues.liferay.com/browse/LPS-166604

The issue is not reproduceable before this commit.

Fix: the offsetHeight is calculated only when the toolbar is positioned for the table
With the fix, the toolbar is positioned again on top of each image and also on top of every cell/row in a table that is currently selected.

Could you please review it?

cc. @markocikos

[markocikos]

@orsolyaDekany Is the bug reproducible in other places where we use alloy editor, or is it specific only to web content on 7.3? I couldn't reproduce it on master Blogs page.

[markocikos]

@orsolyaDekany see comment inline, and also #1543 (comment)

[orsolyaDekany]

Hi @markocikos ,
The fix is specific to 7.3.x and the issue is reproducible in Blogs as well. The issue is not reproducible using Alloyeditor in Blogs on Master, because of another root cause that was a unique fix to 7.3.x, caused by this commit based on my testing. If that change is reverted, the issue is not reproducible in Blogs anymore, however it is still in Web Content. The different behavior might be because of the different editor configurations between the modules, I am not sure.

In the meantime, I also added "startContainer.$.nodeName === "TH", because I realized that header can be set for the columns and rows after creating a table.

[markocikos]

@orsolyaDekany almost good to go! Please see comment inline.

[markocikos]

It looks like this actually fixes a small bug in master, where a text line (paragraph) followed by an image causes wrong positioning. Awesome! I'll trust you that this also fixes the 7.3 bug from the ticket.

Before merging, we should just tidy this a bit. Please move node name to a variable, use single quotes, break line if needed. If you followed setup, you can use yarn format (and yarn test for doublecheck).

[markocikos]

LGTM!