Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ClayCSS] Table title horizontal alignment behavior differs from Chrome to Safari #2219

Closed
diegonvs opened this issue Jul 24, 2019 · 3 comments · Fixed by #2302
Closed

[ClayCSS] Table title horizontal alignment behavior differs from Chrome to Safari #2219

diegonvs opened this issue Jul 24, 2019 · 3 comments · Fixed by #2302
Labels
2.x 3.x browser: safari Issues that happen specifically in Safari browser comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done

Comments

@diegonvs
Copy link
Contributor

diegonvs commented Jul 24, 2019

The left page is running on Chrome and right, on Safari.
Screen Shot 2019-07-24 at 17 21 39

Same comparison on https://next.clayui.com/docs/components/table.html

Screen Shot 2019-07-24 at 17 23 47

Debugging, we are computing text-align: start; on Safari and text-align: inherit; on Chrome. Disabling this property on Safari's debugger, apparently fixed it.
https://recordit.co/MxOMjKswBy

/cc @pat270 @brunofarache

@diegonvs diegonvs added browser: safari Issues that happen specifically in Safari browser comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done labels Jul 24, 2019
@brunofarache
Copy link

brunofarache commented Jul 24, 2019

Thanks for creating this @diegonvs!

Fix should be merged to DXP as it affects all tables there.

@pat270
Copy link
Member

pat270 commented Aug 21, 2019

This is caused by #1743

@zhangyan0701
Copy link

Create https://issues.liferay.com/browse/LPS-100174 for this issue.

pat270 added a commit to pat270/clay that referenced this issue May 21, 2020
…ight` on the `html` element already set on `body`

fix(@clayui/css): Reboot don't set `text-align: left` on `body` due to RTL issues. See liferay#1743

fix(@clayui/css): Reboot remove `:focus-visible` future-proof rule

fix(@clayui/css): Reboot remove uses of Bootstrap's `font-size` and `hover` mixin, we don't support it in Clay CSS

fix(@clayui/css): Reboot remove Bootstrap's `text-align` reset on `th`. See liferay#2219

fix(@clayui/css): Reboot remove Bootstrap's "hand" cursor to non-disabled button elements. We don't support `$enable-pointer-cursor-for-buttons`. We can change the cursor to whatever we want in Clay CSS.

fix(@clayui/css): Reboot use selector `[href]` for styling anchor links instead of `a` so we don't need to overwrite placeholder anchor styles with `a:not([href])`. Styling `<a tabindex="0">a link</a>` should be done with a class like `link-primary`. Trying to avoid going down twbs/bootstrap#24140
pat270 added a commit to pat270/clay that referenced this issue Jun 29, 2020
…ight` on the `html` element already set on `body`

fix(@clayui/css): Reboot don't set `text-align: left` on `body` due to RTL issues. See liferay#1743

fix(@clayui/css): Reboot remove `:focus-visible` future-proof rule

fix(@clayui/css): Reboot remove uses of Bootstrap's `font-size` and `hover` mixin, we don't support it in Clay CSS

fix(@clayui/css): Reboot remove Bootstrap's `text-align` reset on `th`. See liferay#2219

fix(@clayui/css): Reboot remove Bootstrap's "hand" cursor to non-disabled button elements. We don't support `$enable-pointer-cursor-for-buttons`. We can change the cursor to whatever we want in Clay CSS.

fix(@clayui/css): Reboot use selector `[href]` for styling anchor links instead of `a` so we don't need to overwrite placeholder anchor styles with `a:not([href])`. Styling `<a tabindex="0">a link</a>` should be done with a class like `link-primary`. Trying to avoid going down twbs/bootstrap#24140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x 3.x browser: safari Issues that happen specifically in Safari browser comp: clay-css Issues related to Clay CSS type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants