COMMERCE-1621 Liferay 7.2 compatibility!! #1373

ethanbustad · 2019-09-11T23:17:21Z

https://issues.liferay.com/browse/COMMERCE-1621

This works on 7.1.
This works on 7.2 except for a couple frontend issues.

liferay-continuous-integration · 2019-09-11T23:17:26Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

ethanbustad · 2019-09-11T23:17:36Z

ci:test

liferay-continuous-integration · 2019-09-11T23:32:27Z

Validation FAILED.

Build Time: 11 minutes 5 seconds 94 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 340dde62a16243a2ba24b163f701ec834c2b22f8

Task Summary:

subrepository-compile-jdk8 - ❌

     [echo] * What went wrong:
     [echo] Could not resolve all files for configuration ':apps:commerce:commerce-frontend-impl:compileClasspath'.
     [echo] > Could not find com.liferay:com.liferay.portal.template.soy.api:1.3.0.
     [echo]   Searched in the following locations:
     [echo]     - file:/opt/dev/projects/github/liferay-portal-7.1.x/.m2/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - file:/opt/dev/projects/github/liferay-portal-7.1.x/.m2/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]     - http://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - http://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]     - http://repository-cdn.liferay.com/nexus/service/local/repo_groups/private/content/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - http://repository-cdn.liferay.com/nexus/service/local/repo_groups/private/content/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]   Required by:
     [echo]       project :apps:commerce:commerce-frontend-impl
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':apps:commerce:commerce-frontend-impl:compileClasspath'.
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.rethrowFailure(DefaultConfiguration.java:1054)
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.access$1700(DefaultConfiguration.java:123)
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$ConfigurationFileCollection.getFiles(DefaultConfiguration.java:1028)
     [echo] 	at org.gradle.api.internal.file.AbstractFileCollection.iterator(AbstractFileCollection.java:76)

subrepository-semantic-versioning-jdk8 - ❌

     [echo] * What went wrong:
     [echo] Could not resolve all files for configuration ':apps:commerce:commerce-frontend-impl:compileClasspath'.
     [echo] > Could not find com.liferay:com.liferay.portal.template.soy.api:1.3.0.
     [echo]   Searched in the following locations:
     [echo]     - file:/opt/dev/projects/github/liferay-portal-7.1.x/.m2/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - file:/opt/dev/projects/github/liferay-portal-7.1.x/.m2/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]     - http://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - http://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]     - http://repository-cdn.liferay.com/nexus/service/local/repo_groups/private/content/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.pom
     [echo]     - http://repository-cdn.liferay.com/nexus/service/local/repo_groups/private/content/com/liferay/com.liferay.portal.template.soy.api/1.3.0/com.liferay.portal.template.soy.api-1.3.0.jar
     [echo]   Required by:
     [echo]       project :apps:commerce:commerce-frontend-impl
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all files for configuration ':apps:commerce:commerce-frontend-impl:compileClasspath'.
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.rethrowFailure(DefaultConfiguration.java:1054)
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.access$1700(DefaultConfiguration.java:123)
     [echo] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$ConfigurationFileCollection.getFiles(DefaultConfiguration.java:1028)
     [echo] 	at org.gradle.api.internal.file.AbstractFileCollection.iterator(AbstractFileCollection.java:76)

central-requirements-jdk8 - ✔️

For full console, click here.

Test Results:

7 Tests Passed.
0 Tests Failed.

For all test results, click here.

ethanbustad · 2019-09-12T00:49:08Z

I think this won't pass until the changes I made to 7.1 are published, which apparently hasn't been done yet....

ethanbustad · 2019-09-18T20:27:44Z

ci:test
com.liferay.portal.template.soy.api version 1.3.0 is now available on Nexus

liferay-continuous-integration · 2019-09-18T20:55:23Z

Validation FAILED.

Build Time: 24 minutes 1 second 542 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 2fbfe5a1c5e11d030a823c1a61055b28e4971327

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️

subrepository-source-format-jdk8 - ❌

     [echo] java.lang.Exception: Found 2 formatting issues:
     [echo] 1: ./commerce-theme-speedwell/commerce-theme-speedwell/src/WEB-INF/liferay-plugin-package.properties expected:<...eray-versions=7.1.0+[]
     [echo] long-description=
     [echo] m...> but was:<...eray-versions=7.1.0+[,7.2.0+]
     [echo] long-description=
     [echo] m...>
     [echo] 2: ./commerce-theme-minium/commerce-theme-minium/src/WEB-INF/liferay-plugin-package.properties expected:<...eray-versions=7.1.0+[]
     [echo] long-description=
     [echo] m...> but was:<...eray-versions=7.1.0+[,7.2.0+]
     [echo] long-description=
     [echo] m...>
     [echo] 
     [echo] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:438)
     [echo] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:266)
     [echo] 
     [echo] FAILURE: Build failed with an exception.
     [echo] 
     [echo] * What went wrong:
     [echo] Execution failed for task ':checkSourceFormatting'.
     [echo] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 1
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':checkSourceFormatting'.
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [echo] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [echo] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [echo] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)

central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

All of these changes also work in 7.1

ethanbustad · 2019-09-26T19:07:34Z

ci:test

liferay-continuous-integration · 2019-09-26T19:28:09Z

Validation PASSED. Running batch tests.

Build Time: 17 minutes 50 seconds 554 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: c6ce08e1be3a36ca00ae564cd9ed5ae4c90481a5

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-09-26T20:11:51Z

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 3 minutes 58 seconds 790 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: c6ce08e1be3a36ca00ae564cd9ed5ae4c90481a5

13 out of 13 jobs PASSED

13 Successful Jobs:

For more details click here.

marco-leo · 2019-10-01T22:28:35Z

sent to https://github.com/liferay/com-liferay-commerce/tree/7.2.x

liferay-continuous-integration added the ci:test - pending label Sep 11, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Sep 11, 2019

ethanbustad force-pushed the COMMERCE-1621-5 branch from 07967dd to 0b0384f Compare September 12, 2019 00:47

ethanbustad force-pushed the COMMERCE-1621-5 branch 2 times, most recently from 5202235 to 78deb35 Compare September 18, 2019 20:26

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Sep 18, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Sep 18, 2019

marco-leo and others added 12 commits September 26, 2019 11:49

COMMERCE-1621 Making Commerce work on 7.2

8407d9b

COMMERCE-1621 Supply more version ranges to support 7.2

438c873

COMMERCE-1621 Other adjustments to work in 7.2

b6ca9fc

All of these changes also work in 7.1

COMMERCE-1621 Use the 7.2 interface, backported to 7.1

0a546e1

COMMERCE-1621 Use new LocalService method (LPS-97955)

cb01012

COMMERCE-1621 LPS-101074 Adjust to new DDM interface

26b0fde

COMMERCE-1621 LPS-101007 Adjust to new Search interface

674a912

COMMERCE-1621 LPS-101010 Adjust to new Soy interface

feabf86

COMMERCE-1621 Fix checkout-web bnd exports

01ece03

COMMERCE-1621 Work around LPS-101469 until 7.2 SP1

3b38804

COMMERCE-1621 Project dependencies

3ac0f35

COMMERCE-1621 Add missing instance of p_auth in account selector

29625c8

ethanbustad force-pushed the COMMERCE-1621-5 branch from 78deb35 to 29625c8 Compare September 26, 2019 19:04

COMMERCE-1621 Suppress version check to support multi-version compat

be42bc1

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Sep 26, 2019

liferay-continuous-integration added ci:test - success and removed ci:test - pending labels Sep 26, 2019

marco-leo closed this Oct 1, 2019

ethanbustad deleted the COMMERCE-1621-5 branch January 31, 2020 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

COMMERCE-1621 Liferay 7.2 compatibility!! #1373

COMMERCE-1621 Liferay 7.2 compatibility!! #1373

ethanbustad commented Sep 11, 2019

liferay-continuous-integration commented Sep 11, 2019

ethanbustad commented Sep 11, 2019

liferay-continuous-integration commented Sep 11, 2019

Test Results:

For all test results, click here.

ethanbustad commented Sep 12, 2019

ethanbustad commented Sep 18, 2019

liferay-continuous-integration commented Sep 18, 2019

Test Results:

For all test results, click here.

ethanbustad commented Sep 26, 2019

liferay-continuous-integration commented Sep 26, 2019

Test Results:

For all test results, click here.

liferay-continuous-integration commented Sep 26, 2019

Base Branch:

For more details click here.

marco-leo commented Oct 1, 2019

COMMERCE-1621 Liferay 7.2 compatibility!! #1373

COMMERCE-1621 Liferay 7.2 compatibility!! #1373

Conversation

ethanbustad commented Sep 11, 2019

liferay-continuous-integration commented Sep 11, 2019

ethanbustad commented Sep 11, 2019

liferay-continuous-integration commented Sep 11, 2019

Validation FAILED.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

ethanbustad commented Sep 12, 2019

ethanbustad commented Sep 18, 2019

liferay-continuous-integration commented Sep 18, 2019

Validation FAILED.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

ethanbustad commented Sep 26, 2019

liferay-continuous-integration commented Sep 26, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Sep 26, 2019

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 3 minutes 58 seconds 790 ms

Base Branch:

For more details click here.

marco-leo commented Oct 1, 2019