COMMERCE-1835 #1465

andrea-ale-sbarra · 2019-10-02T08:58:28Z

No description provided.

liferay-continuous-integration · 2019-10-02T08:58:32Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

andrea-ale-sbarra · 2019-10-02T08:58:43Z

ci:test

andrea-ale-sbarra · 2019-10-02T09:00:56Z

Hi @ethanbustad, finally I had to redo the PR. Just created a new branch with the same code. I'm sorry for the wrong PR of yesterday. Hope this one is fine.

liferay-continuous-integration · 2019-10-02T09:11:41Z

Validation FAILED.

Build Time: 10 minutes 7 seconds 235 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 6c5a25e3b83d0f44eee68dba5ae05480160f4f49

Task Summary:

subrepository-compile-jdk8 - ✔️

subrepository-semantic-versioning-jdk8 - ❌

     [echo] * What went wrong:
     [echo] Execution failed for task ':apps:commerce:commerce-inventory-api:baseline'.
     [echo] > Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal-7.1.x/tools/sdk/dist/com.liferay.commerce.inventory.api-1.2.1.jar against /opt/dev/projects/github/liferay-portal-7.1.x/.gradle/caches/modules-2/files-2.1/com.liferay.commerce/com.liferay.commerce.inventory.api/1.2.0/ecff34b2e559ae4a2487b79cc0801a679d0ecb64/com.liferay.commerce.inventory.api-1.2.0.jar
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:commerce:commerce-inventory-api:baseline'.
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [echo] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [echo] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [echo] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
     [echo] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

central-requirements-jdk8 - ✔️

For full console, click here.

Test Results:

7 Tests Passed.
0 Tests Failed.

For all test results, click here.

andrea-ale-sbarra · 2019-10-02T09:17:15Z

ci:test

liferay-continuous-integration · 2019-10-02T09:36:32Z

Validation FAILED.

Build Time: 16 minutes 42 seconds 702 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 6c5a25e3b83d0f44eee68dba5ae05480160f4f49

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️

subrepository-source-format-jdk8 - ❌

     [echo] java.lang.Exception: Found 1 formatting issues:
     [echo] 1: ./commerce-service/src/main/java/com/liferay/commerce/service/impl/CommerceShipmentLocalServiceImpl.java expected:<...ommerceShipment.setS[hippingDate(shippingDate);
     [echo] 		commerceShipment.setExpectedDate(expectedDate);
     [echo] 		commerceShipment.setStatus(status]);
     [echo] 
     [echo] 		commerceShipme...> but was:<...ommerceShipment.setS[tatus(status);
     [echo] 		commerceShipment.setShippingDate(shippingDate);
     [echo] 		commerceShipment.setExpectedDate(expectedDate]);
     [echo] 
     [echo] 		commerceShipme...>
     [echo] 
     [echo] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:438)
     [echo] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:266)
     [echo] 
     [echo] FAILURE: Build failed with an exception.
     [echo] 
     [echo] * What went wrong:
     [echo] Execution failed for task ':checkSourceFormatting'.
     [echo] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 1
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':checkSourceFormatting'.
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [echo] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [echo] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [echo] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)

central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

marco-leo · 2019-10-02T15:59:52Z

@andrea-ale-sbarra until validations don't pass I can't review the pull

andrea-ale-sbarra · 2019-10-02T16:09:31Z

Hi @marco-leo I've just run the formatSource task on that module but nothing has changed on my side, how can I make this pass the validation?

ethanbustad · 2019-10-02T18:52:21Z

@andrea-ale-sbarra we have this problem sometimes, where gw formatSource differs between local and CI. I'm trying to figure out the cause, and if I can find it I'll fix it in a separate PR. So I think your PR is fine as-is -- I'll try to remember to retest it once the issue is fixed.

ethanbustad · 2019-10-02T19:06:03Z

ci:test

ethanbustad

Yep, this is perfect, @andrea-ale-sbarra. Thank you!

liferay-continuous-integration · 2019-10-02T19:29:51Z

Validation PASSED. Running batch tests.

Build Time: 20 minutes 59 seconds 855 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 5c4917f81d32cb1bb0bc041a8f3dd8b6f9d20691

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-10-02T20:08:28Z

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 2 minutes 2 seconds 930 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 5c4917f81d32cb1bb0bc041a8f3dd8b6f9d20691

13 out of 13 jobs PASSED

13 Successful Jobs:

For more details click here.

marco-leo · 2019-10-06T20:27:38Z

@andrea-ale-sbarra please rebase this

…oint for extracting WarehouseItem by modifiedDate range, add exception to manage invalid query parameters

andrea-ale-sbarra · 2019-10-07T13:07:38Z

ci:test

liferay-continuous-integration · 2019-10-07T13:33:09Z

Validation PASSED. Running batch tests.

Build Time: 22 minutes 7 seconds 319 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fa8174a94a593653a535cb1a38984d907f449938

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-10-07T13:53:21Z

❌ ci:test - 1 out of 3 jobs passed in 45 minutes 27 seconds 248 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fa8174a94a593653a535cb1a38984d907f449938

1 out of 3 jobs PASSED

2 Failed Jobs:

1 Successful Jobs:

test-subrepository-acceptance-pullrequest-validation(7.1.x)/jdk8

For more details click here.

Failures unique to this pull:

test-subrepository-acceptance-pullrequest-dist(7.1.x)/jdk8

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=tomcat,label_exp=!master #80

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:commerce:commerce-product-content-web:npmInstall'.
     [exec] > java.io.IOException: Process '[/opt/dev/projects/github/liferay-portal-7.1.x/modules/apps/commerce/build/node/bin/node, /opt/dev/projects/github/liferay-portal-7.1.x/modules/apps/commerce/build/node/lib/node_modules/npm/bin/npm-cli.js, --production, false, --registry, http://mirrors.lax.liferay.com:4873, --loglevel, warn, --progress, true, install]' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:commerce:commerce-product-content-web:npmInstall'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [exec] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:59)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)

ethanbustad · 2019-10-07T16:39:13Z

ci:test
weird failure... let's try again and see if it persists

liferay-continuous-integration · 2019-10-07T16:59:31Z

Validation PASSED. Running batch tests.

Build Time: 17 minutes 35 seconds 175 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fa8174a94a593653a535cb1a38984d907f449938

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-10-07T17:42:28Z

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 2 minutes 55 seconds 254 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fa8174a94a593653a535cb1a38984d907f449938

13 out of 13 jobs PASSED

13 Successful Jobs:

For more details click here.

liferay-continuous-integration added the ci:test - pending label Oct 2, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 2, 2019

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Oct 2, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 2, 2019

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Oct 2, 2019

ethanbustad approved these changes Oct 2, 2019

View reviewed changes

liferay-continuous-integration added ci:test - success and removed ci:test - pending labels Oct 2, 2019

andrea-ale-sbarra added 5 commits October 7, 2019 09:41

COMMERCE-1835 added modifiedDate field to WarehouseItem and new end p…

da47247

…oint for extracting WarehouseItem by modifiedDate range, add exception to manage invalid query parameters

COMMERCE-1835 code format (gradle formatSource)

3ab1e67

COMMERCE-1835 switch to project dependencies

cbd1693

COMMERCE-1835 auto generated code (gradle buildREST)

f962b1c

COMMERCE-1835 auto generated code (gradle buildService)

30d5ab6

andrea-ale-sbarra added 2 commits October 7, 2019 14:44

COMMERCE-1835 Semantic Versioning (gradle baseline)

0568339

COMMERCE-1835 fixed some typos

14b957e

andrea-ale-sbarra force-pushed the COMMERCE_1835 branch from 3161dca to 14b957e Compare October 7, 2019 13:06

liferay-continuous-integration added ci:test - pending and removed ci:test - success labels Oct 7, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 7, 2019

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Oct 7, 2019

liferay-continuous-integration added ci:test - success and removed ci:test - pending labels Oct 7, 2019

marco-leo merged commit 4d06993 into liferay:7.1.x-next Oct 7, 2019

andrea-ale-sbarra deleted the COMMERCE_1835 branch December 5, 2019 15:28

COMMERCE-1835 #1465

COMMERCE-1835 #1465

Conversation

andrea-ale-sbarra commented Oct 2, 2019

liferay-continuous-integration commented Oct 2, 2019

andrea-ale-sbarra commented Oct 2, 2019

andrea-ale-sbarra commented Oct 2, 2019

liferay-continuous-integration commented Oct 2, 2019

Validation FAILED.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

andrea-ale-sbarra commented Oct 2, 2019

liferay-continuous-integration commented Oct 2, 2019

Validation FAILED.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

marco-leo commented Oct 2, 2019

andrea-ale-sbarra commented Oct 2, 2019

ethanbustad commented Oct 2, 2019

ethanbustad commented Oct 2, 2019

ethanbustad left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Oct 2, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Oct 2, 2019

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 2 minutes 2 seconds 930 ms

Base Branch:

For more details click here.

marco-leo commented Oct 6, 2019

andrea-ale-sbarra commented Oct 7, 2019

liferay-continuous-integration commented Oct 7, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Oct 7, 2019

❌ ci:test - 1 out of 3 jobs passed in 45 minutes 27 seconds 248 ms

Base Branch:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-subrepository-acceptance-pullrequest-dist(7.1.x)/jdk8

Job Results:

ethanbustad commented Oct 7, 2019

liferay-continuous-integration commented Oct 7, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Oct 7, 2019

✔️ ci:test - 13 out of 13 jobs passed in 1 hour 2 minutes 55 seconds 254 ms

Base Branch:

For more details click here.