COMMERCE-2228 AddToCartButton is aware of product removal in cart #1601

gianmarcobrunialti · 2019-10-26T14:50:50Z

No description provided.

liferay-continuous-integration · 2019-10-26T14:50:56Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

gianmarcobrunialti · 2019-10-26T15:07:54Z

ci:test

liferay-continuous-integration · 2019-10-26T15:33:16Z

Validation FAILED.

Build Time: 21 minutes 39 seconds 475 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fcdbb7a76849c112f5888f4e0b9f71d1beae6a95

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️

subrepository-source-format-jdk8 - ❌

     [echo] java.lang.Exception: Found 1 formatting issues:
     [echo] 1: Reference to variable '_cpInstanceId' does not need '.this': ./commerce-frontend-impl/src/main/java/com/liferay/commerce/frontend/internal/cart/model/Product.java 85 (Checkstyle:NotRequireThisCheck)
     [echo] 
     [echo] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:438)
     [echo] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:266)
     [echo] 
     [echo] FAILURE: Build failed with an exception.
     [echo] 
     [echo] * What went wrong:
     [echo] Execution failed for task ':checkSourceFormatting'.
     [echo] > Process 'command '/opt/java/jdk1.8.0_121-x64/bin/java'' finished with non-zero exit value 1
     [echo] 
     [echo] * Try:
     [echo] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [echo] 
     [echo] * Exception is:
     [echo] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':checkSourceFormatting'.
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:110)
     [echo] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:77)
     [echo] 	at org.gradle.api.internal.tasks.execution.OutputDirectoryCreatingTaskExecuter.execute(OutputDirectoryCreatingTaskExecuter.java:51)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54)
     [echo] 	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:59)
     [echo] 	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:101)
     [echo] 	at org.gradle.api.internal.tasks.execution.FinalizeInputFilePropertiesTaskExecuter.execute(FinalizeInputFilePropertiesTaskExecuter.java:44)
     [echo] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:91)
     [echo] 	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:62)

central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

gianmarcobrunialti · 2019-10-26T16:09:48Z

ci:test

liferay-continuous-integration · 2019-10-26T16:33:51Z

Validation PASSED. Running batch tests.

Build Time: 20 minutes 8 seconds 707 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fcdbb7a76849c112f5888f4e0b9f71d1beae6a95

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-10-26T17:56:10Z

❌ ci:test:default - 3 out of 13 jobs passed in 1 hour 46 minutes 246 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: fcdbb7a76849c112f5888f4e0b9f71d1beae6a95

ci:test:default - 3 out of 13 jobs PASSED

10 Failed Jobs:

3 Successful Jobs:

For more details click here.

Failures (upstream comparison is not available):

test-subrepository-acceptance-pullrequest-batch(7.1.x)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #867

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #956

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/1

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #690

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/2

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #691

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/3

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #562

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

...

ethanbustad · 2019-10-28T18:49:50Z

Error caused by COMMERCE-2283. Working on a fix.

gianmarcobrunialti · 2019-10-28T19:07:46Z

Hey @ethanbustad ! How does your fix relate with this PR? Or you mean the tests randomly failing?

ethanbustad · 2019-10-28T19:24:09Z

@gianmarcobrunialti the tests are failing because private modules aren't resolving -- they have been behind dependency-wise for a while, and I guess a CI change must have started deploying them, so now tests are failing across all PRs. So we just need to fix the dependency issues in the private modules, and this failure should go away -- i.e. the failure is not caused by your changes.

gianmarcobrunialti · 2019-10-28T19:28:05Z

@gianmarcobrunialti the tests are failing because private modules aren't resolving -- they have been behind dependency-wise for a while, and I guess a CI change must have started deploying them, so now tests are failing across all PRs. So we just need to fix the dependency issues in the private modules, and this failure should go away -- i.e. the failure is not caused by your changes.

Thanks for the explanation @ethanbustad !

gianmarcobrunialti · 2019-10-29T13:44:35Z

ci:test

liferay-continuous-integration · 2019-10-29T14:12:51Z

Validation PASSED. Running batch tests.

Build Time: 24 minutes 57 seconds 431 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 3e663171759b65ab67458498b0397d1edcd4f310

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-10-29T15:35:18Z

❌ ci:test:default - 3 out of 13 jobs passed in 1 hour 50 minutes 10 seconds 758 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 3e663171759b65ab67458498b0397d1edcd4f310

ci:test:default - 3 out of 13 jobs PASSED

10 Failed Jobs:

3 Successful Jobs:

For more details click here.

Failures (upstream comparison is not available):

test-subrepository-acceptance-pullrequest-batch(7.1.x)/functional-smoke-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #1070

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #968

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/1

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #694

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/2

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #695

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/3

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #1071

Startup error: Unresolved Requirement(s)

     [exec] 	at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:425)
     [exec] 	at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1577)
     [exec] 	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:309)
     [exec] 	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:424)
     [exec] 	at org.apache.catalina.util.LifecycleBase.setState(LifecycleBase.java:367)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:929)
     [exec] 	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
     [exec] 	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
     [exec] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     [exec] 	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
     [exec] 	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
     [exec] 	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
     [exec] 	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
     [exec] 	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
     [exec] 	at org.apache.catalina.startup.Catalina.start(Catalina.java:634)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
     [exec] 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
     [exec] 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     [exec] 	at java.lang.reflect.Method.invoke(Method.java:498)
     [exec] 	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
     [exec] 	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)

...

ethanbustad · 2019-11-01T03:05:19Z

ci:test

liferay-continuous-integration · 2019-11-01T03:32:57Z

Validation PASSED. Running batch tests.

Build Time: 24 minutes 513 ms

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 03a66d693f8eeab135933e18aa1126a40c2be4a5

Task Summary:

subrepository-compile-jdk8 - ✔️
subrepository-semantic-versioning-jdk8 - ✔️
subrepository-pmd-jdk8 - ✔️
subrepository-source-format-jdk8 - ✔️
central-requirements-jdk8/subrepository-unit-jdk8 - ✔️

For full console, click here.

Test Results:

10 Tests Passed.
0 Tests Failed.

For all test results, click here.

liferay-continuous-integration · 2019-11-01T04:29:48Z

❌ ci:test:default - 11 out of 13 jobs passed in 1 hour 24 minutes 688 ms

Click here for more details.

Base Branch:

Branch Name: 7.1.x
Branch GIT ID: 03a66d693f8eeab135933e18aa1126a40c2be4a5

ci:test:default - 11 out of 13 jobs PASSED

2 Failed Jobs:

11 Successful Jobs:

For more details click here.

Failures (upstream comparison is not available):

test-subrepository-acceptance-pullrequest-batch(7.1.x)/subrepository-functional-tomcat90-mysql57-jdk8/6
Job Results:
1 Test Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #1098
  1. LocalFile.CommerceFrontStore#ViewStoreFrontSimpleProduct - Poshi Report - Poshi Summary - Console Output

commerce-frontend-taglib/src/main/resources/META-INF/resources/mini_cart/MiniCart.es.js

gianmarcobrunialti force-pushed the COMMERCE-2228/AddToCartButtonsResetAppropriately branch from 221752a to d078d1c Compare October 26, 2019 15:07

liferay-continuous-integration added the ci:test - pending label Oct 26, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 26, 2019

gianmarcobrunialti force-pushed the COMMERCE-2228/AddToCartButtonsResetAppropriately branch from d078d1c to eb296cc Compare October 26, 2019 16:09

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Oct 26, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 26, 2019

COMMERCE-2228 AddToCartButton is aware of product removal in cart

0debf07

gianmarcobrunialti force-pushed the COMMERCE-2228/AddToCartButtonsResetAppropriately branch from eb296cc to 0debf07 Compare October 29, 2019 13:43

liferay-continuous-integration added ci:test - pending and removed ci:test - failure labels Oct 29, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Oct 29, 2019

liferay-continuous-integration removed the ci:test - failure label Nov 1, 2019

liferay-continuous-integration added the ci:test - pending label Nov 1, 2019

liferay-continuous-integration added ci:test - failure and removed ci:test - pending labels Nov 1, 2019

marco-leo requested a review from ethanbustad November 2, 2019 07:43

ethanbustad reviewed Nov 4, 2019

View reviewed changes

commerce-frontend-taglib/src/main/resources/META-INF/resources/mini_cart/MiniCart.es.js Show resolved Hide resolved

commerce-frontend-taglib/src/main/resources/META-INF/resources/mini_cart/MiniCart.es.js Show resolved Hide resolved

ethanbustad approved these changes Nov 14, 2019

View reviewed changes

marco-leo merged commit 070a86d into liferay:7.1.x-next Nov 25, 2019

COMMERCE-2228 AddToCartButton is aware of product removal in cart #1601

COMMERCE-2228 AddToCartButton is aware of product removal in cart #1601

Conversation

gianmarcobrunialti commented Oct 26, 2019

liferay-continuous-integration commented Oct 26, 2019

gianmarcobrunialti commented Oct 26, 2019

liferay-continuous-integration commented Oct 26, 2019

Validation FAILED.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

gianmarcobrunialti commented Oct 26, 2019

liferay-continuous-integration commented Oct 26, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Oct 26, 2019

❌ ci:test:default - 3 out of 13 jobs passed in 1 hour 46 minutes 246 ms

Base Branch:

10 Failed Jobs:

For more details click here.

Failures (upstream comparison is not available):

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

ethanbustad commented Oct 28, 2019

gianmarcobrunialti commented Oct 28, 2019

ethanbustad commented Oct 28, 2019

gianmarcobrunialti commented Oct 28, 2019

gianmarcobrunialti commented Oct 29, 2019

liferay-continuous-integration commented Oct 29, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Oct 29, 2019

❌ ci:test:default - 3 out of 13 jobs passed in 1 hour 50 minutes 10 seconds 758 ms

Base Branch:

10 Failed Jobs:

For more details click here.

Failures (upstream comparison is not available):

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

ethanbustad commented Nov 1, 2019

liferay-continuous-integration commented Nov 1, 2019

Validation PASSED. Running batch tests.

Base Branch:

Task Summary:

For full console, click here.

Test Results:

For all test results, click here.

liferay-continuous-integration commented Nov 1, 2019

❌ ci:test:default - 11 out of 13 jobs passed in 1 hour 24 minutes 688 ms

Base Branch:

2 Failed Jobs:

For more details click here.

Failures (upstream comparison is not available):

Job Results: