Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

liferay-theme-tasks 10.0.0-alpha.1+gulp 4.0.0 on Windows - Generated theme is deployed as a portlet instead of a theme, and it cannot be applied to site. #458

Closed
zhangyan0701 opened this issue Apr 1, 2020 · 1 comment
Closed

liferay-theme-tasks 10.0.0-alpha.1+gulp 4.0.0 on Windows - Generated theme is deployed as a portlet instead of a theme, and it cannot be applied to site. #458

zhangyan0701 opened this issue Apr 1, 2020 · 1 comment
Assignees
@izaera
Labels
bug
Milestone
IFI-1529 Add Node...

Comments

@zhangyan0701
Copy link

Steps to reproduce:

  1. Generate a theme with JS Theme Toolkit v9.5.0.
  2. Edit the theme's package.json and point liferay-theme-tasks to "10.0.0-alpha.1" and gulp to "^4.0.0".
  3. rm -rf node_modules (just in case).
  4. rm package-lock.json (just in case).
  5. Run npm install again.
  6. Navigate to theme's root folder.
  7. Run 'gulp build'.
  8. Copy the war file into portal/deploy.
  9. Go to Control Panel > Component.

Expected Result:
The generated theme should be listed in Themes tab.

Actual Result:
The generated theme is listed in Portlets tab.
not a theme
@izaera izaera added the bug label Apr 1, 2020
@izaera izaera self-assigned this Apr 2, 2020
@izaera
Copy link
Member

izaera commented Apr 3, 2020

Commented this while investigating this issue, which seems closely related to #457.

@izaera izaera mentioned this issue Apr 3, 2020
Closed
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
docs: liferay#458 specify that paths must be POSIX
ee119fb 
Any path given from outside (config files or APIs) must be POSIX so that
configuration is platform independent.
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
chore: liferay#458 add dependency
4775e08 
We will use liferay-npm-build-tools-common to handle path with the FilePath
class.

Note that we already have liferay-npm-build-tools-common as a dependency in the
generator, and that this package will be used to contain common JS Toolkit code
in the near future.
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 create Options class
b6b71f2 
Instead of using a plain object, we will make a class with structure to hold
options.

This is to be able to track changes to the options schema, type each value, and
detect incorrect usages (thus the Object.freeze, to avoid spurious storage of
options).
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 convert default paths to POSIX
eb84d6d
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 retrieve options from project object
209faa3 
This is to make more explicit that those options are the ones inside Project.
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 use FilePath in production code
740bda9 
Adapt code to previous change of project.options.
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 use FilePath in test code
614ccac 
Adapt code to previous change of project.options.
izaera pushed a commit to izaera/liferay-js-themes-toolkit that referenced this issue Apr 6, 2020
@ivan-zaera
refactor: liferay#458 don't freeze project.options
5649d5f 
Seeing there are no more assignments to project.options left in the code and as
per conversation
liferay#464 (comment)
@izaera izaera closed this as completed Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@izaera izaera

Labels
bug
Projects
None yet
Milestone
IFI-1529 Add Node v12 Support to Them...
Development

No branches or pull requests
2 participants
@izaera @zhangyan0701