Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-3209 #5833

Closed
wants to merge 95 commits into from
Closed

LPD-3209 #5833

wants to merge 95 commits into from

Conversation

brianikim
Copy link
Member

@brianikim brianikim commented Feb 2, 2024

From: brianikim#137

Cause for error here: brianchandotcom#146864 (comment)

You will get that error if you try to run ant format-source-current-branch while not having ran npm install in modules/test/playwright

brittneyq and others added 30 commits February 2, 2024 05:38
…lso scheduled web content when the number of recent items displayed is changed
Mikellorza and others added 26 commits February 2, 2024 07:05
…lt separator as a journal article friendly url separator
…untDownLatch instead of thread sleep to avoid save configuration delay. Method updateConfiguration(String pid, UnsafeRunnable<Exception> unsafeRunnable) is configured to expect two countDown for the registered manager, so we are forcing to update the configuration again and the manager is executed so the countDown is executed again
@brianikim
Copy link
Member Author

ci:reopen

@brianikim
Copy link
Member Author

only SF failure I get with this rebased PR from here is the following:

format-source-files:
     [java] Loading file:/home/brian/Repo/liferay-portal/liferay-portal/portal-impl/classes/system.properties
     [java] Incorrect commit message: Missing breaking change in commit messages when the major version bumps up: ./portal-impl/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
     [java] SLF4J: Class path contains multiple SLF4J bindings.
     [java] SLF4J: Found binding in [file:/home/brian/Repo/liferay-portal/liferay-portal/util-slf4j/classes/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: Found binding in [jar:file:/home/brian/Repo/liferay-portal/liferay-portal/lib/development/slf4j-simple.jar!/org/slf4j/impl/StaticLoggerBinder.class]
     [java] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
     [java] SLF4J: Actual binding is of type [com.liferay.util.slf4j.LiferayLoggerFactory]
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: Incorrect commit message: Missing breaking change in commit messages when the major version bumps up: ./portal-impl/bnd.bnd (SourceCheck:BNDBreakingChangeCommitMessageCheck)
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:458)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:291)

Above failure caused by: d76c6084

@brianikim brianikim closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet