Lpd 3472 final test #5877
Closed
Lpd 3472 final test #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cale. # breaking ## What modules/apps/commerce/commerce-api/src/main/java/com/liferay/commerce/util/CommerceQuantityFormatter.java modules/apps/commerce/commerce-api/src/main/java/com/liferay/commerce/util/CommerceQuantityFormatter.java has a new method parse(BigDecimal quantity, Locale locale); ## Why this change is required to correctly parse non-US locale inputs for price and quantity. ---- # breaking ## What modules/apps/commerce/commerce-api/src/main/java/com/liferay/commerce/util/CommerceOrderItemQuantityFormatter.java modules/apps/commerce/commerce-api/src/main/java/com/liferay/commerce/util/CommerceOrderItemQuantityFormatter.java has a new method format(CommerceOrderItem commerceOrderItem, Locale locale); ## Why this change is required to correctly format non-US locale inputs for price and quantity. ----
# breaking ## What modules/apps/commerce/commerce-discount-api/src/main/java/com/liferay/commerce/discount/exception/CommerceDiscountMinPriceValueException.java modules/apps/commerce/commerce-discount-api/src/main/java/com/liferay/commerce/discount/exception/CommerceDiscountMinPriceValueException.java was introduced as a new exception; ## Why this change is required to validate for min price values. ---- # breaking ## What modules/apps/commerce/commerce-price-list-api/src/main/java/com/liferay/commerce/price/list/exception/CommercePriceListMinPriceValueException.java modules/apps/commerce/commerce-price-list-api/src/main/java/com/liferay/commerce/price/list/exception/CommercePriceListMinPriceValueException.java was introduced as a new exception; ## Why this change is required to validate for min price values. ---- # breaking ## What modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/exception/CPInstanceMinPriceValueException.java modules/apps/commerce/commerce-product-api/src/main/java/com/liferay/commerce/product/exception/CPInstanceMinPriceValueException.java was introduced as a new exception; ## Why this change is required to validate for min price values. ----
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-3472
@luca-pellizzon ,
I tested the front-end in SKU/UOM Edit view, Inventory, and also discounts.
Please let me know if I missed anything.