-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-27880 Delete DatasetViewDateFilters.tescase #5953
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck the result. Remove poshi counterpart
…ilter modal. Remove poshi counterpart
…poshi counterpart
…new dateRangeFilter tests
…more than one filter. Remove poshi counterpart
…ng DSM date filter. Remove poshi counterpart
…DSM filter associated. Remove poshi counterpart
… when REST Schema has no date fields. Remove poshi file DataSetViewDateFilters.testcase
ci:test:playwright |
ci:test:sf |
ooh, wrong fork 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are improving PW coverage of Date Filters in DSM and getting rid of old poshi tests related to this part of the DSM.
Reference: https://liferay.atlassian.net/browse/LPD-27691
@markocikos @chestofwonders for the Refactor PR, Miguel is working on tests that should leverage changes I'm adding here (pls see
FiltersPage.ts
)