Lpd 24185 #5963
Closed
Lpd 24185 #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smottal
reviewed
Jun 12, 2024
Comment on lines
7360
to
7361
| feature.flag.LPD-21636.description=Users can define and manage a Picklist to configure Product Specification value. | ||
| feature.flag.LPD-21636.title=Configure Specification value with Picklist |
There was a problem hiding this comment.
value should not be values? (in both the sentences)
There was a problem hiding this comment.
actually the value for the specification is only one
There was a problem hiding this comment.
@JamesAGarcia can you please have a look at this? Thank you!
smottal
reviewed
Jun 12, 2024
smottal
approved these changes
Jun 12, 2024
andrea-ale-sbarra
force-pushed
the
LPD-24185
branch
from
a383b14
to
bb1cdf6
Compare
andrea-ale-sbarra
force-pushed
the
LPD-24185
branch
from
bb1cdf6
to
5342203
Compare
|
ci:test:sf |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
ci:forward:force |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-24185