LSR-931 Expose User object in SessionContext #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM |
|
👍 |
jmnavarro
suggested changes
Nov 23, 2016
| @@ -72,7 +72,7 @@ public class LoginScreenlet: BaseScreenlet, BasicAuthBasedType { | |||
| viewModel.userName = SessionContext.currentContext?.basicAuthUsername | |||
| viewModel.password = SessionContext.currentContext?.basicAuthPassword | |||
|
|
|||
| let userAttributes = SessionContext.currentContext!.userAttributes | |||
There was a problem hiding this comment.
Add a computed property called userAttributes to maintain backwards compatibility
| @@ -48,11 +48,11 @@ public class UpdateCurrentUserLiferayConnector: ServerConnector { | |||
| } | |||
|
|
|||
| public func attributeAsString(key: String) -> String { | |||
| return SessionContext.currentContext?.userAttribute(key) as! String | |||
There was a problem hiding this comment.
Same here: add userAttribute(key) method.
Keep in mind the Liskov Substitution Principle, or as a simple rule of thumb: don't chain more than one period in an expression (don't access one object internals, just ask the object to do something)
| @@ -79,7 +79,7 @@ public class UserPortraitScreenlet: BaseScreenlet { | |||
| } | |||
|
|
|||
| public func loadLoggedUserPortrait() -> Bool { | |||
| guard let userId = SessionContext.currentContext?.userId else { | |||
|
|
||
| super.init() | ||
| } | ||
|
|
||
| private func int64Value(key: String) -> Int64? { |
There was a problem hiding this comment.
Move these helper methods to somewhere?
jmnavarro
approved these changes
Nov 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.