Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug with the node_type variable in _get_children_player_node(...) #2

Closed
snarb opened this issue Jul 7, 2017 · 0 comments
Closed

bug with the node_type variable in _get_children_player_node(...) #2

snarb opened this issue Jul 7, 2017 · 0 comments

Comments

@snarb
Copy link

snarb commented Jul 7, 2017 •
edited
Loading

Looks like you accidentally store node type in the check_node.type variable in one place:

DeepStack-Leduc/Source/Tree/tree_builder.lua

Line 123 in bd344ca

check_node.type = constants.node_types.check
and in the chance_node.node_type in other

DeepStack-Leduc/Source/Tree/tree_builder.lua

Line 134 in bd344ca

chance_node.node_type = constants.node_types.chance_node
. Is this a bug? I can make a PR if you confirm.
@snarb snarb changed the title bug in the node_type variable in _get_children_player_node(...) bug with the node_type variable in _get_children_player_node(...) Jul 7, 2017
@snarb snarb closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@snarb