Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When component is generated it should be in a separate folder #13

Closed
farisT opened this issue Jun 4, 2019 · 3 comments
Closed

When component is generated it should be in a separate folder #13

farisT opened this issue Jun 4, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@farisT
Copy link
Collaborator

farisT commented Jun 4, 2019

As title says, this should link with liftr-framework/skeleton#12 so that all the components have their own folder in their respective root folders. There can also be a flag to create within the component root folder itself instead of creating a folder.

@farisT farisT added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 4, 2019
@theghostyced
Copy link

Hi, @farisT Am looking to pick this up but I don't quite understand the full definition of a component. At first, I thought you were referring to a controller but then realized you already had a script for that.

So before I pick it up, can you shed a little light on it 💡?

@farisT
Copy link
Collaborator Author

farisT commented Jun 30, 2019

Hi @theghostyced, glad to see you are interested in picking this up. Just to clarify, the definition of a component is a route, middleware or controller. At the moment these are created within their specific folders with the titles "Routes", "Middleware", "Controllers".
The idea of this issue was to be able to have the choice to create one of these components within that folder but have their own sub-directory (with possibly a flag)

So when I create a middleware file with liftr -m MyMiddleware it should be created in the "Middleware" folder but be in its own sub-directory.

Schermafbeelding 2019-06-30 om 14 48 14

Maybe if you create a --flat flag it defaults to the current behaviour (just create in the middleware folder, no sub-directory)

So the previous command would look like liftr -m MyMiddleware --flat.

Hope this is enough information for you to work with!

@farisT
Copy link
Collaborator Author

farisT commented Oct 28, 2019

This was completed in https://github.com/farisT/liftr-cli/releases/tag/v2
Closing issue

@farisT farisT closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants