PathParser.fastPathBuild array allocation seems to do nothing #730
Comments
|
Looks true to me! Wouldn't be the first time a thing called "fast" in some code was... not fast. 🙃 |
|
A |
|
Wow—nice catch! |
hkupty
changed the title
|
Nice.. I can open a PR to fix - essentially removing those two lines above. Not sure if that's the intended behavior of this function though. |
hkupty
added a commit
to hkupty/config
that referenced
this issue
May 18, 2021
Usage of this array seems to have been dropped by lightbend#280, but the array remained. Cleaning up so it doesn't allocate the array needlessly anymore. Fixes lightbend#730.
This was referenced May 18, 2021
|
Nice catch. I removed it from sconfig as well. |
hkupty
added a commit
to hkupty/config
that referenced
this issue
May 21, 2021
Usage of this array seems to have been dropped by lightbend#280, but the array remained. Cleaning up so it doesn't allocate the array needlessly anymore. Fixes lightbend#730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I was investigating some performance bottlenecks of an application and interestingly this array allocation appears to be on the on the hotpath. On this 5 minute scan,
PathParser.fastPathBuildwas responsible for ~6.15% of the 1.23GB object array allocation of the system.When checking, it seems that the array is allocated but never used. seems like its usage was dropped as of this commit, but it was left there. Is that the case?
The text was updated successfully, but these errors were encountered: