Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should huggingface_hub be added to requirements.txt? #96

Closed
emilesilvis opened this issue May 26, 2023 · 5 comments · Fixed by #97
Closed

Should huggingface_hub be added to requirements.txt? #96

emilesilvis opened this issue May 26, 2023 · 5 comments · Fixed by #97

Comments

@emilesilvis
Copy link
Contributor

No description provided.

@carmocca
Copy link
Contributor

carmocca commented May 26, 2023

Downloading weights is not strictly required to use the project. For instance, to pretrain the model.

This is why that package is not part of requirements.txt

@emilesilvis
Copy link
Contributor Author

Makes sense! If desired, I can edit the README to add pip install huggingface_hub where required.

@carmocca
Copy link
Contributor

Good idea. But you should add it to the howtos about downloading data, not the README

@emilesilvis
Copy link
Contributor Author

#97

@nahakiole
Copy link

I ran into the issue after following the tutorial here again: https://lightning.ai/pages/blog/falcon-a-guide-to-finetune-and-inference/

Maybe a idea would be to use the extras_require feature in the setup.py and create multiple versions?

extras_require={
    'download':  ['huggingface_hub'],  # These are additional requirements for the "download" version
},

Then we could add pip install .[download] to the documentation.
I think it would be important to add this in the main readme.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants