-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option_closing_rejected: turn-based fee_range coop close (feature 60/61) #1016
base: master
Are you sure you want to change the base?
Conversation
Commentary from the latest spec meeting:
|
Concept ACK. I would add a I think it would be confusing to use a
If we had a shortage of available message types I would understand the need to create that additional layer of indirection, but since we don't have such a shortage adding such indirection is creating unnecessary complexity? |
Should the above be changed so that if you are sending |
Yes, I believe we should replace the use of warning with this new Of course, if others disagree with my previous comment and think we should extend warning/error instead of introducing a new message, this point would be moot. |
|
||
1. type: 40 (`closing_rejected`) | ||
2. data: | ||
* [`channel_id`:`channel_id`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment from spec meeting: should this also include a fee range in this message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were going with the whole warnings approach for telling what parameters you didn't like about any message?
Adds a feature bit. It's optional, but does simplify some of the spec logic and I think it's nice to have. The naming can change. It works with simple-taproot-channels to allow sending musig2 nonces in a turn-based way.
Fixes #1013