Update config defaults and expose them in bindings #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2023-06-update-sync-constants
branch
from
be8331e
to
f901285
Compare
We choose constants that reduce the chance of overlapping syncs past the initial one.
As we expect LDK Node to be primarily used as a client, we should be conservative about listening/accepting inbound connections. The user should make a dedicated choice to do so.
tnull
force-pushed
the
2023-06-update-sync-constants
branch
from
f901285
to
4f8703d
Compare
|
Rebased after #115 was merged. |
jkczyz
approved these changes
Jun 20, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #115.Closes #120.
We update config defaults to make them a bit more robust.
In particular, we
listening_addressdefault toNoneto have the use make a dedicated choice whether to accept inbound connections or not.Configdefaults in UniFFI bindings (Set config defaults in bindings #120)