-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds getting started installation instructions #133
Conversation
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
a176cda
to
bab6603
Compare
No need to hold this PR up, but I think we're getting close over at ldk-swift land to make a presence in this page too. I'll submit a PR when we're ready :) |
docs/tutorials/getting-started.md
Outdated
Example usage after installation is complete: | ||
:::: tabs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if the language tabs here and the previous box were synced. I think that had been done in one of the guides when we had more than one example per page prior to breaking it up into subpages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @dennisreimann seems like it's possible on page load but not when you actually click a single tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does kinda work with anchor links e.g tutorials/getting-started/#java
but does this weird page jump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran across this which may help? vuejs/vuepress#851 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
03764a8
to
29edeeb
Compare
<CodeSwitcher :languages="{rust:'Rust', java:'Java', kotlin:'Kotlin', javascript:'JavaScript'}"> | ||
<template v-slot:rust> | ||
|
||
```toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation levels seem inconsistent across the first CodeSwitcher
block, FWIW. The second block seems fine though with two spaces and one within the formatted language blocks.
Preview