deps: update react-scripts to v5.0.0 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaljsr
force-pushed
the
update-cra
branch
3 times, most recently
from
cfe669a
to
ba4f66f
Compare
jamaljsr
force-pushed
the
update-cra
branch
2 times, most recently
from
1132174
to
a10b47c
Compare
guggero
reviewed
Apr 4, 2022
| @@ -1,5 +1,5 @@ | |||
| # Start with a NodeJS base image that also contains yarn. | |||
| FROM node:12.17.0-buster as nodejsbuilder | |||
| FROM node:16.14.2-buster as nodejsbuilder | |||
There was a problem hiding this comment.
We also need to bump this version in the Dockerfile and dev.Dockerfile, otherwise I get error react-scripts@5.0.0: The engine "node" is incompatible with this module. Expected version ">=14.0.0". Got "12.17.0"
There was a problem hiding this comment.
Ah, good catch. I updated those two files in 0233f27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
react-scriptsnpm dependency along with a few other related packages. I also needed to resolve some breaking changes due to the upgrades ofwebpackandjest.Replaces the following PRs:
The dependabot PRs above apply updates to the dependencies of our dependencies by patching the
yarn.lockfile. I typically prefer not to use those because you end up playing a game of wack-a-mole. Once you close one PR, another one pops up shortly afterwards. The better approach is to figure out which top level dependencies need to be updated, and update them. That is what this PR is doing. All of those package updates, plus more, are included in the update toreact-scripts.To test, you just need to load the site and click around a bit to ensure there are no console errors.