Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

itest: Add custom channels with grouped asset test #781

Merged

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR adds a new itest that uses a grouped asset, in order to tackle some of the issues discovered in lightninglabs/taproot-assets#947

Closes lightninglabs/taproot-assets#957

@GeorgeTsagk GeorgeTsagk self-assigned this Jun 25, 2024
@guggero
Copy link
Member

guggero commented Jun 25, 2024

Looks like the grouped asset itest fails consistently when sending a payment. Does that happen as well for you locally?

@GeorgeTsagk
Copy link
Member Author

Looks like the grouped asset itest fails consistently when sending a payment. Does that happen as well for you locally?

Nope, locally it passes consistently, and on Github CI it's flaky

@GeorgeTsagk GeorgeTsagk force-pushed the custom-channels-grouped-itest branch from 0046505 to fb870e4 Compare June 26, 2024 09:34
@dstadulis dstadulis requested a review from guggero June 26, 2024 11:41
@guggero guggero force-pushed the custom-channels-grouped-itest branch 3 times, most recently from b52ee68 to 91372ac Compare June 26, 2024 14:29
@guggero
Copy link
Member

guggero commented Jun 26, 2024

The flake will be fixed by lightningnetwork/lnd#8871. Not sure if we should get this in while flakey and then wait for the CI to become fully green in #782 which bumps all dependencies?

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I'm in favor of merging this, even if the itest doesn't pass yet. I've confirmed that lightningnetwork/lnd#8871 will fix this, so it's just a matter of bumping the lnd dependency after merge, which #782 will do anyway.

@GeorgeTsagk
Copy link
Member Author

The flake will be fixed by lightningnetwork/lnd#8871. Not sure if we should get this in while flakey and then wait for the CI to become fully green in #782 which bumps all dependencies?

I'm fine both ways, since we know it's a flake we could hit the merge prematurely

@guggero guggero force-pushed the custom-channels-grouped-itest branch 2 times, most recently from 4b0c87f to 7805c4d Compare June 26, 2024 20:23
@guggero guggero force-pushed the custom-channels-grouped-itest branch from 32a9735 to 77b6af9 Compare June 26, 2024 21:08
@guggero guggero merged commit b439354 into lightninglabs:0-19-staging Jun 26, 2024
12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants