Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments and invoices filtering by creation date #7159

Merged
merged 8 commits into from
Dec 5, 2022

Conversation

yyforyongyu
Copy link
Collaborator

Replaces #6544 and #6542. Updates from the original PRs

  • the validation of datetime params are placed in rpc server, not in channeldb
  • update cli to use the new fields

@saubyk saubyk linked an issue Nov 15, 2022 that may be closed by this pull request
@yyforyongyu yyforyongyu self-assigned this Nov 15, 2022
@yyforyongyu yyforyongyu added this to the v0.16.0 milestone Nov 15, 2022
@saubyk saubyk linked an issue Nov 15, 2022 that may be closed by this pull request
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for picking this up!
Only nits 🎉

lnrpc/lightning.proto Outdated Show resolved Hide resolved
channeldb/invoice_test.go Outdated Show resolved Hide resolved
channeldb/invoices.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
lnrpc/lightning.proto Outdated Show resolved Hide resolved
channeldb/payments.go Outdated Show resolved Hide resolved
channeldb/payments_test.go Outdated Show resolved Hide resolved
@yyforyongyu yyforyongyu force-pushed the code-review-6542 branch 2 times, most recently from 76c77aa to 0ffd833 Compare November 25, 2022 13:41
Copy link
Collaborator

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yyforyongyu I just left a couple of comments about the params description.

I will make sure that this changes are incorporated in #7215

lnrpc/lightning.proto Outdated Show resolved Hide resolved
lnrpc/lightning.proto Outdated Show resolved Hide resolved
cmd/lncli/cmd_invoice.go Show resolved Hide resolved
@guggero guggero merged commit e23c5dc into lightningnetwork:master Dec 5, 2022
@yyforyongyu yyforyongyu deleted the code-review-6542 branch December 5, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filtering options on REST /v1/invoices Add filtering options on REST /v1/payments
5 participants