funding+htlcswitch: enforce min fee rate of 253 sat/kw on commitments #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we add and enforce a min fee rate for commitment transactions created, and also any updates we propose to the remote party. It's important to note that this is only a temporary patch, as nodes can dynamically raise their min fee rate whenever their mempool is saturated. Fixes lightningnetwork#1330.
cfromknecht
reviewed
Jun 6, 2018
| // minCommitFeePerKw is the smallest fee rate that we should propose | ||
| // for a new fee update. We'll use this as a fee floor when proposing | ||
| // and accepting updates. | ||
| minCommitFeePerKw = 253 |
There was a problem hiding this comment.
Do we need a separate value for LTC?
There was a problem hiding this comment.
Spec doesn't define any such value. LTC really doesn't have fees, so shouldn't be much of an issue for them...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add and enforce a min fee rate for commitment
transactions created, and also any updates we propose to the remote
party. It's important to note that this is only a temporary patch, as
nodes can dynamically raise their min fee rate whenever their mempool is
saturated.
Fixes #1330.