[tests] Force tick on FwdEventTicker #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
fwdtrigger-force
branch
2 times, most recently
from
dbf5d6c
to
e2527b9
Compare
halseth
changed the title
halseth
force-pushed
the
fwdtrigger-force
branch
from
e2527b9
to
d4c19d8
Compare
halseth
force-pushed
the
fwdtrigger-force
branch
from
d4c19d8
to
9efacc9
Compare
halseth
added
testing
halseth
force-pushed
the
fwdtrigger-force
branch
from
9efacc9
to
4c021c3
Compare
wpaulino
reviewed
Dec 20, 2018
htlcswitch/switch_test.go
Outdated
| bobLog.Lock() | ||
| t.Fatalf("expected 5 events in event log, instead "+ | ||
| "found: %v", spew.Sdump(bobLog.events)) | ||
| bobLog.Unlock() |
There was a problem hiding this comment.
Perhaps this should be deferred? The t.Fatal call shouldn't allow it to get to this point.
EDIT: not that it matters much I guess, since the tests will halt anyway.
There was a problem hiding this comment.
True, good catch :)
halseth
force-pushed
the
fwdtrigger-force
branch
from
4c021c3
to
c9868aa
Compare
wpaulino
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures events are properly flushed on
FwdEventTick. Should also help with the flaky coverage reports.