Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htlcswitch/mock: decrease interval fwd+log tickers #2251

Conversation

cfromknecht
Copy link
Contributor

Allows more reliable coverage results for
the htlcswitch package. Initially pointed
out by @offerm in #1641.

Allows more reliable coverage results for
the htlcswitch package. Initially pointed
out by @offerm in lightningnetwork#1641.
@Roasbeef Roasbeef added testing Improvements/modifications to the test suite P4 low prio needs review PR needs review by regular contributors labels Dec 3, 2018
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕐

@halseth
Copy link
Contributor

halseth commented Dec 11, 2018

I think #1975 should go in first, as it deterministically force ticks.

@cfromknecht
Copy link
Contributor Author

Closing since #1975 should be more reliable, can reopen if issue comes up again

@cfromknecht cfromknecht closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PR needs review by regular contributors P4 low prio testing Improvements/modifications to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants