travis - allow tickers to tick for coverage #1641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a sleep of 16 seconds to one of the tests to make sure that the logTicker and the fwdEventicker have time to tick. Without this these ticker may not tick during coverage test which may lead to reduction of coverage.
|
Once #1668 is in, then we can ensure that all the tickers always tick, which will ensure that we aren't penalized coverage wise for this. |
|
Ticker package is merged, can this PR be altered to force a tick instead of waiting for it to happen? |
|
@offerm Did you try to force a tick? |
|
Closing in favour of #1975. |
cfromknecht
added a commit
to cfromknecht/lnd
that referenced
this pull request
Dec 1, 2018
Allows more reliable coverage results for the htlcswitch package. Initially pointed out by @offerm in lightningnetwork#1641.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a sleep of 16 seconds to one of the tests to make sure that the logTicker and the fwdEventicker have time to tick. Without this, these tickers may not tick during coverage test which may lead to a reduction of coverage.
See discussion in #1590