Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate value types in TS for core (classes for keys) #14

Closed
Yousif-FJ opened this issue Feb 14, 2024 · 2 comments
Closed

Investigate value types in TS for core (classes for keys) #14

Yousif-FJ opened this issue Feb 14, 2024 · 2 comments
Labels
core This issue for the core component (backend of the frontend)
Milestone
Sprint 2

Comments

@Yousif-FJ
Copy link
Contributor

No description provided.

@Yousif-FJ Yousif-FJ added the core This issue for the core component (backend of the frontend) label Feb 14, 2024
@Yousif-FJ
Copy link
Contributor Author

e.g. cellKey, groupKey should be classes themselves to avoid passing incorrect key types.

@Yousif-FJ Yousif-FJ mentioned this issue Feb 19, 2024
Closed
@lakosd lakosd added this to the Sprint 2 milestone Feb 19, 2024
@Yousif-FJ Yousif-FJ assigned Yousif-FJ and unassigned Yousif-FJ Feb 21, 2024
@julkunensuvi
Copy link
Contributor

Drafted 2 possible solutions, 1. using abstraxt class and wrappers and 2. using tagged types

@rafinutshaw rafinutshaw linked a pull request Feb 29, 2024 that will close this issue
UI Prototype #1 #34
Merged
@Yousif-FJ Yousif-FJ removed a link to a pull request Mar 4, 2024
UI Prototype #1 #34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core This issue for the core component (backend of the frontend)
Projects
None yet
Milestone
Sprint 2
Development

No branches or pull requests
3 participants
@lakosd @Yousif-FJ @julkunensuvi