Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing loading state in Battery Saver #244

Open
graciouselectric opened this issue May 6, 2024 · 1 comment
Open

Confusing loading state in Battery Saver #244

graciouselectric opened this issue May 6, 2024 · 1 comment

Comments

@graciouselectric
Copy link

Dear developer,

I noticed that when I enable Battery Saver on Android 8.1, the indeterminate ProgressBars in the app are not properly shown. This is a known problem in Android API level <28, see e.g. this StackOverflow question. Battery Saver disables animations, also on progress bars on these versions. This is quite confusing because the loading state is not properly represented. It is fixed in later Android versions, where progress bars do appear and animate.

Looking at the code, indeterminate progress bars are created here:

className='org.ligi.gobandroid_hd.ui.tsumego.fetch.DownloadProblemsDialog', lineNumber=17
className='org.ligi.gobandroid_hd.ui.UnzipSGFsDialog', lineNumber=16

To fix this issue, one can check ValueAnimator.areAnimatorsEnabled() and provide a different UI element, such as a text label, when animations are disabled.

I also recorded a video, showing one instance of the issue in practice:

org.ligi.gobandroid_hd.mov
@ildar
Copy link

ildar commented May 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants