Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mock to allow testing of file finders #8

Merged
merged 6 commits into from
Jun 3, 2016
Merged

Use mock to allow testing of file finders #8

merged 6 commits into from
Jun 3, 2016

Conversation

duncanmmacleod
Copy link
Member

This PR introduces better unit tests of each of the ETG finder methods, using mock to fake the _find_in_gps_dirs step that would require the files to actually exist.

@duncanmmacleod duncanmmacleod self-assigned this Jun 2, 2016
@coveralls
Copy link

coveralls commented Jun 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+43.4%) to 69.421% when pulling 8697d39 on duncanmmacleod:coverage into 5902161 on ligovirgo:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+56.6%) to 82.645% when pulling 2ab013a on duncanmmacleod:coverage into 5902161 on ligovirgo:master.

@coveralls
Copy link

coveralls commented Jun 3, 2016 •
edited
Loading

Coverage Status

Coverage increased (+56.6%) to 82.645% when pulling 2ab013a on duncanmmacleod:coverage into 5902161 on ligovirgo:master.

@duncanmmacleod duncanmmacleod merged commit 63a8e9a into gwpy:master Jun 3, 2016
@duncanmmacleod duncanmmacleod deleted the coverage branch June 3, 2016 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@duncanmmacleod duncanmmacleod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanmmacleod @coveralls