Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test version of function to locate pycbc live files #9

Merged
merged 6 commits into from
Jun 30, 2016

Conversation

ahnitz
Copy link
Contributor

@ahnitz ahnitz commented Jun 23, 2016

This adds a function to find pycbc live files. It will only work currently for the files available for testing purposes. (which only cover 9/14/15 - 9/16/15). I'm working on getting a shared account for this data, so the basename string will need to be updated when that happens.

@coveralls
Copy link

coveralls commented Jun 23, 2016

Coverage Status

Coverage decreased (-11.1%) to 71.528% when pulling f25f9fa on ahnitz:master into 63a8e9a on ligovirgo:master.

@duncanmmacleod
Copy link
Member

hey @ahnitz, this looks great. Any chance you can take a look at the test_trigfind.py script and write up a unittest method for the new function?

@coveralls
Copy link

coveralls commented Jun 25, 2016

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 964d0ab on ahnitz:master into 63a8e9a on ligovirgo:master.

@duncanmmacleod
Copy link
Member

so, the test case doesn't run on travis-ci.org because the builder isn't set up to install lal, but presuming it runs on LDAS (will test), this looks very nice, thanks.

@ahnitz
Copy link
Contributor Author

ahnitz commented Jun 27, 2016

That's right. I think re-add the test case skip in this case, as it can't import the gps time conversion functions.

@coveralls
Copy link

coveralls commented Jun 27, 2016

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 680bb02 on ahnitz:master into 63a8e9a on ligovirgo:master.

@ahnitz
Copy link
Contributor Author

ahnitz commented Jun 27, 2016

Doesn't seem to be much I can do about the decrease in coverall score though, since it can't actually test the function in the online travis.

@duncanmmacleod
Copy link
Member

@ahnitz, I've tested things using the available data on LHO, and it works very well. Can you please correct the trailing whitespace errors in both test_trigfind.py and trigfind/core.py, then I will be very happy to merge.

@coveralls
Copy link

coveralls commented Jun 28, 2016

Coverage Status

Coverage decreased (-10.4%) to 72.222% when pulling 7d9f9cb on ahnitz:master into 63a8e9a on ligovirgo:master.

@duncanmmacleod
Copy link
Member

I've been able to test this end-to-end, looks great, thanks @ahnitz.

@duncanmmacleod duncanmmacleod merged commit be52dcc into gwpy:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants