Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Migrate from oss-licenses-plugin to Licensee #916

Closed
1 task done
Goooler opened this issue Jul 11, 2024 · 1 comment · Fixed by #919
Closed
1 task done

[FR]: Migrate from oss-licenses-plugin to Licensee #916

Goooler opened this issue Jul 11, 2024 · 1 comment · Fixed by #919

Comments

@Goooler
Copy link
Contributor

Goooler commented Jul 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the problem

Now we depend on com.google.android.gms:play-services-oss-licenses to generate the license page, which is not configuration cache compatible and relies on AppCompat themes. We can migrate to Licensee instead, which will eliminate AppCompat libs and significantly decrease the app size.

<activity
android:name="com.google.android.gms.oss.licenses.OssLicensesMenuActivity"
android:theme="@style/Theme.AppCompat" />
<activity
android:name="com.google.android.gms.oss.licenses.OssLicensesActivity"
android:theme="@style/Theme.AppCompat" />

Describe the solution

Refs

Additional context

No response

@lihenggui
Copy link
Owner

lihenggui commented Aug 27, 2024

Migration completed.

We can migrate to Licensee instead, which will eliminate AppCompat libs and significantly decrease the app size.

I can't find much difference in the app size after removing the OSS license plugin.
Before: 8597201 bytes.
After: 8283953 bytes.
It reduced the size of the installation package by 4%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants