Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel 3 (Wave) OFF not emulated correctly #538

Open
coffeevalenbat opened this issue Apr 15, 2023 · 3 comments
Open

Channel 3 (Wave) OFF not emulated correctly #538

coffeevalenbat opened this issue Apr 15, 2023 · 3 comments

Comments

@coffeevalenbat
Copy link

So I've been messing around with getting the cleanest possible sample playback from channel 3, I modified some sample code from GB Studio and tried it out on a few emulators, at first I was happy that it sounded clean as water on Sameboy, as that's where I always test sound stuff first, but after I got some friends to test it on real hardware and other emulators, it seems like the issue is Sameboy being too good. It lacks the click noise heard while channel 3 is off (IE, when rAUD3ENA is 0). While this does make for a better sounding experience, it is also misleading and innacurate.

Sameboy:

SameBoy.v0.15.8.2023-04-15.16-10-00.mp4

MGBA (I cannot test on real hardware myself right now, but I was told real hardware [At least a GB Pocket] sounds like this):

mGBA.-.SAMPLECLEAR.59.8.fps.-.0.10.1.2023-04-15.16-09-36.mp4

For testing, here is the ROM in question, the sample plays when the player presses the B button.

@Buggem
Copy link
Contributor

Buggem commented Apr 20, 2023

I'm a bit confused here. Why is this guy in the top corner around 0 seconds in?
AC81301E-3EE3-4704-B382-FBEA958620C3

@coffeevalenbat
Copy link
Author

...that is my cursor :P

@carmiker
Copy link
Contributor

For the record, Gambatte sounds like the second video posted (like mGBA or ostensibly real hardware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants