Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate internal defnc components with ^:private metac #65

Closed
SevereOverfl0w opened this issue Jun 16, 2020 · 3 comments
Closed

Generate internal defnc components with ^:private metac #65

SevereOverfl0w opened this issue Jun 16, 2020 · 3 comments

Comments

@SevereOverfl0w
Copy link
Contributor

When completing you get both -render-type and -item-render-type for the component. I think these should be private instead, thoughts?

@lilactown
Copy link
Owner

That makes sense to me. This is only when using factory functions, and you should be able to use helix.core/type to get the render fn from the factory fn if needed.

@SevereOverfl0w
Copy link
Contributor Author

That's so useful, I've been breaking the rules then!

@lilactown
Copy link
Owner

Undocumented code might as well not exist 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants