-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite tests in Go #127
Comments
Am looking into taking this up. To support tests for both vz and qemu drivers and also try to make it more stable (tests passing in first run and not via retries). Also github actions now supports macos-13 runner in beta. Is there any specific approach we need to take here ?? |
FWIW, I agree with rewriting the Perl bits, but I don't think Go is an appropriate language for integration tests (obviously it is the correct choice for unit tests). I think using a framework like BATS (combined with Having said that, whoever is going to spend the time on implementing this should have the final word on how it is done. 😄 |
As an example of using BATS, creds.bats is a Rancher Desktop integration test that makes sure you can access a registry. It uses some helper scripts, so it runs on macOS, Linux, and Windows (in WSL) and can test both moby and containerd configurations (and on Windows can test both Linux and Windows binaries to talk to moby/containerd). I very much like the brevity and simplicity of the test code, making it easy to write and change the tests once you understand how the helper functions make it work in the different environments. E.g. |
The current test suite is written in bash and perl, but we should rewrite tests in Go
The text was updated successfully, but these errors were encountered: