-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running a test suite sometimes aborts #2
Comments
wow i haven't been around this code for a bit ... please provide a test example that fails ... regardless i'll look into it tonight |
First of all, thanks for providing this project. It was very useful for us. |
cool got it ... i'll mess with an echo test passing a long string |
your code is right on the money ... but i'll implement it based on the expected length of the command ... the first 6 digits ... it shouldn't take long to do |
Hey mbarchfe .. I just released a new version with the fix ... please let me know if it works to close the issue Thank you |
Hi Mike, Thanks for the patch. Unfortunately, it did not work with umlaute. I have created a pull request with a fix and further explanations. Also, one test was broken and I have added new tests for the umlaut-stuff. BTW: could you describe somewhere how to run the complete test suite? I ran it with the command below, but that seems awkward. (cd ../src; coffee -c *.coffee); mocha slim_chunk_buffer_spec.js server_spec.js command_spec.js calls_spec.js import_spec.js serialize_response_spec.js |
ok i merged the pull request ... did some cleanup and re-org ... i didn't tuned package.json 100% yet but the idea is to do npm install and then npm test ... that leaves u in autotest mode ... u could just run mocha from the main dir now if u dont want the autotest stuff (u need the latest coffeescript installed globally) now back to the issue ... i don't think it is fixed ... i tried a test with an umlaut n' it is crashing badly ... please notice the unit tests are not that interesting ... the important tests are in slim ... for that u could c the startFitNesse batch n' get fitnesse running ... once in there u could check out this test ... http://localhost:8080/ExampleS.EchO ... in particular the piece ... |script|Echo | ... so yeah i guess the response serializer needs to count utf-8 properly too ... i'll work on it tomorrow Thank you very much |
Hi, thanks for restructuring the tests to run with mocha. I prefer to run them that way. The serialised issue is funny: it seems as if the slim client does not handle incoming utf-8 in the same way as outgoing. I have implemented a serialiser which counts 2 for every utf-8 char, but the java slim deserialiser uses string.substring() to cut the string and that counts 1 for every utf-8 char. cheers |
Ok thank you for the excellent patch. It was merged and i did some cleanup around the serializer area ... i still don't know why i got 2 classes in 1 file n' exported as functions ... bahh experimenting ... anyways a new version was released please let me know if it solves the problem. Thank you very much for your code and time dedicated to this issue |
Vielen Dank auch Dir, Mike. One final issue: when I reinstalled via npm I found a lot of new files, like startFitNesse.bat and all the test files. was that your intention? |
nahh i wasnt neat enuf ... just pushed a cleaner version ... danke schoon |
Hello,
running a test suite sometimes aborts if the data event is fired with only a part of the data written from the SLIM client.
Below is a possible patch. However, checking for completeness ist not perfect. isComplete should actually try to deserialize the message and only if that succeeds continue.
The text was updated successfully, but these errors were encountered: