Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection is very slow [$5 awarded] #406

Closed
simonzack opened this issue Oct 11, 2014 · 11 comments · Fixed by limetext/lime-qml#20
Closed

Selection is very slow [$5 awarded] #406

simonzack opened this issue Oct 11, 2014 · 11 comments · Fixed by limetext/lime-qml#20

Comments

@simonzack
Copy link

simonzack commented Oct 11, 2014

Selection & editing a selection are quite slow in the qt gui (when editing main.go in the lime source).

I understand that the qt gui is in early alpha and am not familiar with the code base, but just wanted to raise my concern as I think making the gui reasonably fast up front is rather important.

--- The **[$5 bounty](https://www.bountysource.com/issues/5225519-selection-is-very-slow?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** on this issue has been claimed at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).
@snowiow
Copy link
Contributor

snowiow commented Oct 12, 2014

Isn't that the problem because of the millions of print outs, which are currently in the qml code? Didn't tested it without them yet, but always thought that they are slowing the gui down.

@quarnster
Copy link
Member

I've not seen slow selection, but I have seen it freeze/hang completely after selecting a bit of text. Though I haven't had a chance to look into that yet.

@sardonic2
Copy link

I've seen the same thing. Text selection bogs down a bit, until it hangs / white screens completely. To add a bit to that, it looks to flatline a core to 100% CPU, and will not respond until I kill the proccess.

@pwaller
Copy link

pwaller commented Mar 31, 2015

Yes, the cursor movement in general is unusably slow for me.

@crr0004
Copy link

crr0004 commented Mar 31, 2015

I know with selection at the moment there is possible issue with reverse selection and selecting outside the window causes a hang

@quarnster
Copy link
Member

This was improved recently with d897c29. Was this the "slow selection" you talked about, or was it something else? The selection-hang is handled in #535

@pwaller
Copy link

pwaller commented Apr 14, 2015

I can confirm that Selection fluidity seems improved since last time I tried it. However, there are still a number of other selection and performance bugs. For example, double clicking on a word frequently doesn't select what I expect it to. And performance wise the editor takes quite a while to display the text with the correct indentation when it starts.

@quarnster
Copy link
Member

@pwaller, yes, it's very early days still and we need more people helping out with tweaking all those bits (and many more). Please help us by keeping discussions about specific issues in separate issue numbers

@simonzack
Copy link
Author

I just compiled this (on arch linux), and selection is still slow for lime_qml. The more lines I select the slower it becomes. Try selecting 20 lines and the editor becomes unusable.

@quarnster
Copy link
Member

For that, the culprit is onSelectionModified in LimeView.qml as it takes longer and longer to complete the more lines are selected. It could be improved quite a bit by instead of completely re-creating all the selection regions for all selected lines, to just tweak the lines that have changed between the last selection and the new one. Marking as enhancement

@quarnster
Copy link
Member

Or perhaps more correct, selection should be handled in the backend which has knowledge of color schemes etc. The frontend then only needs to track and render cursor positions seperately.

@erbridge erbridge modified the milestone: v0.1 Apr 17, 2015
@quarnster quarnster changed the title Selection is very slow Selection is very slow [$5] Sep 1, 2015
@quarnster quarnster changed the title Selection is very slow [$5] Selection is very slow [$5 awarded] Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants