Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add commands to verify the integrity of the downloaded file #5

Closed
wolfg1969 opened this issue Jun 29, 2014 · 10 comments
Closed

Comments

@wolfg1969
Copy link
Contributor

Such like md5sum, sha1sum, gpg, etc.

@wolfg1969 wolfg1969 changed the title Add commands to verify the integrity of the downloaded file Feature: add commands to verify the integrity of the downloaded file Jun 29, 2014
@limodou
Copy link
Owner

limodou commented Jun 29, 2014

Can you provide more details? For example:

zlib = cp('zlib*', BUILD, wget='http://zlib.net/zlib-1.2.8.tar.gz', md5sum='xxxxxxx')

or

wget('http://zlib.net/zlib-1.2.8.tar.gz', md5sum='xxxxxxx')

Something likes these?

@wolfg1969
Copy link
Contributor Author

Yes. For md5sum or sha1sum, it's simple:

wget('http://zlib.net/zlib-1.2.8.tar.gz', md5sum='44d667c142d7cda120332623eab69f40')

or

wget('http://download.redis.io/releases/redis-2.8.12.tar.gz', sha1sum='56c86a4f9eccaf29f934433c7c67a175e404b2f6')

But for gpg signature, there are more steps to do:

wget http://nginx.org/download/nginx-1.7.2.tar.gz.asc
gpg --import KEYS
gpg --verify nginx-1.7.2.tar.gz.asc

@limodou
Copy link
Owner

limodou commented Jun 29, 2014

We can leave gpg later, I think the md5 and sha1 are more usage.

@wolfg1969
Copy link
Contributor Author

Sure.

@wolfg1969
Copy link
Contributor Author

@limodou I can do something for this feature in next week.

@limodou
Copy link
Owner

limodou commented Jun 29, 2014

Ok, you are welcome.

@wolfg1969
Copy link
Contributor Author

Just commit some codes. Pls check it. will update docs later.

@wolfg1969
Copy link
Contributor Author

@limodou Thanks for the refactor. Do you want to implement the PGP check next?

@limodou
Copy link
Owner

limodou commented Jul 7, 2014

I don't know how to implement it now. And if there are some requirements, maybe we can implement it. If it does not need so much, maybe we don't need to do it now I think.

@limodou limodou closed this as completed Jul 7, 2014
@wolfg1969
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants