Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devfee address FIRST record in coinbase PLEASE #7

Open
kr1z1s opened this issue Jan 23, 2018 · 8 comments
Open

Make devfee address FIRST record in coinbase PLEASE #7

kr1z1s opened this issue Jan 23, 2018 · 8 comments

Comments

@kr1z1s
Copy link

kr1z1s commented Jan 23, 2018

Why did you check devfee address the second record coinbase???

if (vtx[0].vout[1].scriptPubKey != scriptPubKey)

WHY second?

Make the first record coinbase
vtx[0].vout[0]

I can't in p2pool make your address the second

I have an array of addresses. I can't break.

@linX-project
Copy link
Owner

Hi Kr1z1s,

Sorry that's not possible. We had to do it this way for across the board compatibility reasons. vout[0] is a continuation of what went before (50 Linx).

We do value your input to the community and hope that you can find a way to make it work.

Kind regards

@kr1z1s
Copy link
Author

kr1z1s commented Jan 23, 2018

How to be located the records in coinbase?

You - first? Or you - second?

p2pool Generates an array of records in coinbase

Usually they are from 0 to N-1 (The number of wallets)

How to place records in coinbase?

@mammix2
Copy link
Collaborator

mammix2 commented Jan 23, 2018

Hi kr1z1s
The records must be added in the coin base like this.
vout0: 50 LINX
vout1: 2.5 LINX

As you have much experince with p2pool, this should be possible.
The getblocktemplate RPC call against the deamon shows the coinbase requierements

Kind Regards

@himikk
Copy link

himikk commented Jan 24, 2018

That's awful. Why are you guys don't tell anything about cool new feature 5% fee?
And if you even add the fee you need to do it correctly as other coins do.
You need to add all charity data to getblocktemplate output.
Are this data correct?
charityvalue_address XF7kCcs4woQD9WWnCHuN6SWPeUNK2fBspr
charityvalue 2.5

@kr1z1s
Copy link
Author

kr1z1s commented Jan 24, 2018

This is really awful.

I had to stop the node. I deleted my project p2pool-linx from github

Now this coin is not compatible with p2pool

I can't do so
vout0: 50 LINX
vout1: 2.5 LINX

The main feature p2pool - generated transactions

Coins initially prescribed in coinbase

https://chainz.cryptoid.info/linx/tx.dws?432675.htm

It used to be

You know?

@mammix2
Copy link
Collaborator

mammix2 commented Jan 24, 2018

@himikk , Yes the data is correct.
address XF7kCcs4woQD9WWnCHuN6SWPeUNK2fBspr
charityvalue: 2.5 LINX
Regarding the template, as adminstrators you are very experienced with running pools, we were sure that you would be able to account for the changes. We know alot of other coins have their charity value in vout[0] but as we already have other services that are integrating with Linx they are expecting the same 50 LINX in vout[0], so we had to put the charity value in vout[1]. We published all the changes needed to make this work with NOMP in the other repo https://github.com/linX-project/linx-unomp-pool-settings.

To adjust the getblocktemplate to suit your pool make this change in the Linx source;

Below this line,
https://github.com/linX-project/linX/blob/master/src/rpcmining.cpp#L550

Add this extra line of code.
result.push_back(Pair("charityvalue", (int64_t)pblock->vtx[0].vout[1].nValue));


@kr1z1s, Anything is possible. Please explain in detail why p2pool is not compatible with Linx now that the charityvalue is in vout[1] ? Is it the 'getblocktemplate ' ?
We only have experience with NOMP and MPOS, but we are here to help you all.

Thanks

@ilsawa
Copy link

ilsawa commented Jan 25, 2018

For this transaction https://chainz.cryptoid.info/linx/tx.dws?432675.htm it is seen that on the vout more than 2:

{
"txid": "93627d1366ca652460512eee7c239ca95caad00716d69d0fbf549201327f9ad3",
"version": 1,
"locktime": 0,
"vin": [
{
"coinbase": "0326ce042cfabe6d6def5a8d1fa21f6e62d777aa2dddd4e56fb47343ef74359387c492b0667733f0021000000000000000062f503253482f",
"sequence": 4294967295
}
],
"vout": [
{
"value": 0.01051183,
"n": 0,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 78f47fe3c1df474ea0120848de79bab6a9b8ff5e OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a91478f47fe3c1df474ea0120848de79bab6a9b8ff5e88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XNNnqHuu6ynPQimRtAAQLWJaSZQpzMxN28"
]
}
},
{
"value": 0.02328317,
"n": 1,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 f1c60dc77af4cb5d4d5f8391dd63ddfa1769e859 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914f1c60dc77af4cb5d4d5f8391dd63ddfa1769e85988ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XZPcxPypf5rs3twMdPCRsuRvkN5mstCx9z"
]
}
},
{
"value": 0.04183531,
"n": 2,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 992d866a26c9062aeea582e5fb4bb4292fb09eae OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914992d866a26c9062aeea582e5fb4bb4292fb09eae88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XRKAmda9JuScDNHsEtzTXHs82sB1uq3mFG"
]
}
},
{
"value": 0.05881795,
"n": 3,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 41f819b01009fa5a418100578d14512737d83ee5 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a91441f819b01009fa5a418100578d14512737d83ee588ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XHN3yvmctQQUrj67iSsu9joTPH2RoRBk4i"
]
}
},
{
"value": 0.09261484,
"n": 4,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 5ea268ddb0592e8ce16d6f2fd845b1da0577d75c OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9145ea268ddb0592e8ce16d6f2fd845b1da0577d75c88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XKycvbXLhxv1MK7SvjnjmdtNALyB4Er9vA"
]
}
},
{
"value": 0.09893901,
"n": 5,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 3f821e550bafb2e1a9589aa4b8745a834b59b7de OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9143f821e550bafb2e1a9589aa4b8745a834b59b7de88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XH93J2B2F9hkGd66w2pMz8psz3RwoARwkE"
]
}
},
{
"value": 0.25407086,
"n": 6,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 a554a861d1059e0bee587d293f7272303fa232d7 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914a554a861d1059e0bee587d293f7272303fa232d788ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XSRRkvK2BfJKhjfB9fTBAxPUpcxfJhXWbM"
]
}
},
{
"value": 0.69842824,
"n": 7,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 4236fd2138ce4725c97d4ec7f91b627d2540d28b OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9144236fd2138ce4725c97d4ec7f91b627d2540d28b88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XHPMKVawd6fYQV94ZZQUMDdtjGUHoJhKbX"
]
}
},
{
"value": 1.8588525,
"n": 8,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 a350e3c5a1b1276427a9d8fea9521ed66f1dcf45 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914a350e3c5a1b1276427a9d8fea9521ed66f1dcf4588ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XSEmtjKgJe6WMj9Gks2EvogsBWRQkgEYyU"
]
}
},
{
"value": 2.0375769,
"n": 9,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 176dc1321e953447b1400e653296395179bbe30d OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914176dc1321e953447b1400e653296395179bbe30d88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XDV7sSmvhpNQYFvvSfradgkSi9HVqtVt1N"
]
}
},
{
"value": 2.25912566,
"n": 10,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 28768aaa075b25bb23205706746ddc057767da2a OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a91428768aaa075b25bb23205706746ddc057767da2a88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XF3BtEgsnri33sCgFL7bW78ZivAVrU96fG"
]
}
},
{
"value": 2.54539935,
"n": 11,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 b5b6e6e59de360d6cc7d7fd9e9ed9bc42d8aae1d OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914b5b6e6e59de360d6cc7d7fd9e9ed9bc42d8aae1d88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XTv4G7fx1TMw5hi65rcNtYrFboyfZDotYb"
]
}
},
{
"value": 2.70243451,
"n": 12,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 84e8642a3c57a9395d15197ac0392b2a2d7a10e6 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a91484e8642a3c57a9395d15197ac0392b2a2d7a10e688ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XPTzSJ4WmRY1aBRog8q3Ky9P6LqN6iJweH"
]
}
},
{
"value": 2.71657816,
"n": 13,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 cf28002a0610a9a9c2376a25217e9a057e3f4cdd OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914cf28002a0610a9a9c2376a25217e9a057e3f4cdd88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XWEae9UvPwecunN5mNhHpdJpW8zeSnJxTq"
]
}
},
{
"value": 2.75279819,
"n": 14,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 a01392f228c1ff4f3954bca349c7e040f1ddc879 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914a01392f228c1ff4f3954bca349c7e040f1ddc87988ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XRweQs3VyihVwmhcd2e8gjQDcXTdiLDioy"
]
}
},
{
"value": 3.12735534,
"n": 15,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 9f49fc33e18ca85c1eeb3c2b72b1af73d8682744 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9149f49fc33e18ca85c1eeb3c2b72b1af73d868274488ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XRsUvE2XgKnvYLH1HDUfsmiNRKhL4YfbvB"
]
}
},
{
"value": 3.29280962,
"n": 16,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 364f68a2637c97451904f45fa8f8aab20a80905d OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914364f68a2637c97451904f45fa8f8aab20a80905d88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XGJQTvFHBFf5ExSeq527CgNJU33m7Juoiq"
]
}
},
{
"value": 4.51649765,
"n": 17,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 6de18a2ce6459a295a4679e0af147bb4802f1e3c OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a9146de18a2ce6459a295a4679e0af147bb4802f1e3c88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XMNEgq8zwCLUGhrcZ5SFcEaLYXiu2MmLvM"
]
}
},
{
"value": 4.78125021,
"n": 18,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 a587f7e60307d0486b0fedeb9c29022c9fc8138a OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914a587f7e60307d0486b0fedeb9c29022c9fc8138a88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XSSVE3VJRK9vZbFYXL2QZF1AEkvwJpi4r9"
]
}
},
{
"value": 6.96886878,
"n": 19,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 aacffed36e1ad596277d5ab4560b90c4c878a6ff OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914aacffed36e1ad596277d5ab4560b90c4c878a6ff88ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XSvQtXjg2xKbvaiDq1LbdZxWts3vEZ8d7A"
]
}
},
{
"value": 8.79438388,
"n": 20,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 cf4e9ad8664a37a7a2c1de88f3840c15f577aa06 OP_EQUALVERIFY OP_CHECKSIG",
"hex": "76a914cf4e9ad8664a37a7a2c1de88f3840c15f577aa0688ac",
"reqSigs": 1,
"type": "pubkeyhash",
"addresses": [
"XWFNtR41LU4ZQVCxRQcoooa6BmqudC86bP"
]
}
},
{
"value": 0.36856804,
"n": 21,
"scriptPubKey": {
"asm": "2 02535950c76051ba0cec2c65ad94d84072274ea28b86ce9d61702ee9dcd5dfbde7 0358bffde1f44aa783a9f9109459a045a98e75ca374b7636f31ff6e90eb9a43c4a 2 OP_CHECKMULTISIG",
"hex": "522102535950c76051ba0cec2c65ad94d84072274ea28b86ce9d61702ee9dcd5dfbde7210358bffde1f44aa783a9f9109459a045a98e75ca374b7636f31ff6e90eb9a43c4a52ae",
"reqSigs": 2,
"type": "multisig",
"addresses": [
"XY7B6KksBwh3ZExzhGQZKLwMYU5mMYYx88",
"XPUVAWD3bm7Eqx7PwwVPMpwVmyzBueAs9G"
]
}
},
{
"value": 0,
"n": 22,
"scriptPubKey": {
"asm": "OP_RETURN cc8fa6a03ffe0f3e3c8b5758dcbb9d9c3c0446b0d0894b275bfb12ba9e1f17090000000002000000",
"hex": "6a28cc8fa6a03ffe0f3e3c8b5758dcbb9d9c3c0446b0d0894b275bfb12ba9e1f17090000000002000000",
"type": "nonstandard"
}
}
],
"blockhash": "17d375c153e4a8d0c0042f0ef2e910942e9a277e837b046132e6b3c02ead57b3",
"confirmations": 2454,
"time": 1516687540,
"blocktime": 1516687540
}

vout from 0 to 22 - this is a payment to workers of the p2pool. They can be more than 22.
Put a payout check on the developers for the last vout and do not limit the number of vout by 2.

@himikk
Copy link

himikk commented Jan 26, 2018

@mammix2 As easiest way implement Linx charity/coinbase unusual order in the stratum.
It will be good to put charity value to block template data in the next release.
Please keep me in touch if something will changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants