FIX: select folder callback error on mac #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error by using the multiprocessing library to keep process in the main thread.
|
Folder loading works fine on my side too! On a side note (not for this PR), we should probably gracefully fail (e.g., pop up a message windows mentioning that this loaded path is not a BIDS project, or a LL output...) on a call to |
Awesome!!! and agreed, that is a good idea. |
|
@Andesha would you mind pulling this branch and trying out the select folder button, on your Linux computer? |
|
can confirm this works for me |
|
awesome! I am going to rebase with main and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
This works on my mac. Fixes the error we were getting by using the
multiprocessingmodule tokeep the process in the main threadexecute this action in a separate process.@christian-oreilly Can you review/pull this branch and test it out on your side? (NOTE: this branch is on the lina-usc remote, NOT my fork.)