-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No "+" button when responding to a message and hard to find how to join a Drive file to the discussion (attachment) #133
Labels
Milestone
Comments
RomaricMourgues
added a commit
that referenced
this issue
Sep 29, 2020
### Summary This commit contain a 2 weeks sprint on Twake messages feed and fix several frontend bugs. 1. A lot of work was put into improving our infinite scroll component. We needed to allow the following: - Ability to render only visible messages for performances - To load more on top, or load more on bottom without having unwanted scroll jump - Keep scroll smooth when rerendering out of view messages or when messages content change We used a simple implementation to ensure a given message node called 'witness' (defined as the node in the center of view or the highlighted node if defined) doesn't move in the view if the user didn't scroll. The difficulty is in the fact that it is very hard to differenciate a user triggered scroll from a content change triggered scroll. Everything is in /twake/frontend/src/app/services/Apps/Messages/MessagesListUtils.ts 2. We also put a lot of work in the message input, now availables actions (such as uploading a file) are more visible. We also improved our input to have it available from thread answers. 3. We improved the way threads are working. From now on, answers to old thread are shown on the bottom of the discussion with a link to the thread. It should be easier to not have lost messages. 4. Some new small features: - Ability to get a link to a specific thread or message - New emojis using currently the Apple emoji listing - Drag-and-drop handler - Responsive threads view for small screens ### Architecture decisions We tried to use React Virtualized list, without success because we have rows of unknown height and the fact that we need infinite scroll to the top and to the bottom. We saw the new React Window by the same developer, it doesn't fit our needs. After some search we needed to implement our own infinite scroller. ### Issues Closes #12 Closes #13 Closes #16 Closes #133 Closes #181 Closes #185 Closes #157 Closes #233 Closes #234 Closes #243 Closes #251 Closes #278 Closes #279 Closes #280 Closes #281 ### History * Start working on new messages * Update * Continue new list * End message list service * Start imlementing react virtualized * Fix backend issues * Advancement on lists * Working first infinite scroll version * Fix small issues * Detect first message (init_channel) * Add animated scroll * Fix workspace privilege for company identity bug * 🌟 Add channel description feature Closes #165 * Improve scroll jumps * 🌟 Add user card popup when somebody is mentionned in conversation (#254) Closes #74 * Implement new "WitnessMessage" solution * 🛠 Fix header alignment * Add ability to jump to a message * Implement websockets to update messages list * 🛠 Fix delete workspace button (#257) Closes #247 * 🛠 Fix error when leaving last workspace of a company (#258) Closes #245 * Add responses * Hide unwanted messages during loading * Do not render all messages at once * Ability to jump on init * 🛠 Remove import company members table (#260) Closes #250 * Fix scroll to message and render on scroll * Bump symfony/http-kernel from 4.4.6 to 4.4.13 in /twake/backend/core Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 4.4.6 to 4.4.13. - [Release notes](https://github.com/symfony/http-kernel/releases) - [Changelog](https://github.com/symfony/http-kernel/blob/master/CHANGELOG.md) - [Commits](symfony/http-kernel@v4.4.6...v4.4.13) Signed-off-by: dependabot[bot] <support@github.com> * Change icons, add reactions * Improve files in messages * Re-implement messages options * Add linkable messages * Add descending messages (no ui) * Add style to descending messages * Fix error with width * Fix Drive UI * Add go to end button * End of week * Fix 2 sentry errors * Prepare input and fix sentry errors * Update emoji picker * Fix infinite loop * Started MessageEditors service * Fix channels categories and message text editor * Reimplementing apps in input * Reimplement time separators * Re-implement drag and drop * Fix header alignement * Fix app icons in messages * Fix ephemeral messages * Fix jitsi not in thread * Fix time separator ui * Re-implement drag-drop of files * Dbug drag+drop * Re-implement file upload from computer * Fix drag file UI * Prepare edition * Fix last message increment on muted channel quoted msg * Reimplement message edition * Change LocalStorage * Fix local storage * Fix too many items in localstorage * Fix unable to get too long message for edition * Save before going back in time * Re-fix scroll stabilizer * Fix scroll for link to message in channel feature * Fix last message scroll alignement * Fix time for new message * Fix locked scroll to bottom on send message * Fix inputs auto-comlete and openning * Fix reconnexion to collections * Improve scroll a bit and fix collections Co-authored-by: Stéphane Vieira <36481167+stephanevieira75@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Hi @RomaricMourgues what do you mean by (+) button? And what did you do to improve the process of joining a Drive file to a discussion? |
Hello Ha,
On the previous Twake version, if you click on “Answer” there is no “+” button to select a file from computer.
Now you should have every buttons (gif, call, file etc) even in the reply button.
Romaric
… On 1 Oct 2020, at 10:05, Ha Nguyen ***@***.***> wrote:
Hi @RomaricMourgues <https://github.com/RomaricMourgues> what do you mean by (+) button?
And what did you do to improve the process of joining a Drive file to a discussion?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#133 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNQMBA6UZFC2L4BBIEANCTSIQZ3LANCNFSM4QFF4LWA>.
|
Ok it makes sense. Actually now you don't have (+) button but you have icons for attachment/emoji/video call for user to choose, which makes it easier for user. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No description provided.
The text was updated successfully, but these errors were encountered: