-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content Display] Frontend: Update global design and logic of the preview modal #2404
Comments
Hi @RomaricMourgues! Here are some bugs I noticed (MacOS).
|
@tprudentova could you test again this on QA ? I cannot reproduce it but I added something that should fix it on devices like iPhones and iPads, may be that's your case ? |
@RomaricMourgues all of the bugs or some certain one? |
The 1 and 4 sorry :) |
Do you use an iPad for testing ? |
@RomaricMourgues nope, I use MacBook and it's not fixed for it :( I believe the problem is with scaling, because I can see the menu bar if I zoom out (zooming out to maximum for images with description and zooming out a little for sole images) |
This time it should be good for the 1 and 4. 3 should also be better. |
@RomaricMourgues 1, 3 and 4 work fine! |
5 is done too :) |
US: https://www.notion.so/linagora/Content-display-An-image-gallery-30475bbbac704d69a9654bf8e944cd24
Update design of the preview modal to match the new UI.
This modal will take as argument a messages-file primary key and get from backend the message-file with context #2401 .
Next and previous buttons will be added using result from #2401 .
Modals context and buttons will also be added except for this list of actions: Save as, rotate image, zoom in, zoom out, video player, delete, share/forward. This actions will be implemented in another version.
The text was updated successfully, but these errors were encountered: