Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 Added link preview in the frontend #2228

Merged
merged 9 commits into from
Jun 7, 2022

Conversation

rezk2ll
Copy link
Member

@rezk2ll rezk2ll commented Jun 3, 2022

Description

  • adds the link preview

Related Issue

#2217

Motivation and Context

  • display previews for links detected in messages.

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

previewDemo.mp4

image
image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added the Signed-off-by statement at the end of my commit message.

@rezk2ll rezk2ll changed the title #2217 🌟 added link preview in the frontend Jun 3, 2022
@rezk2ll rezk2ll linked an issue Jun 3, 2022 that may be closed by this pull request
@RomaricMourgues
Copy link
Contributor

Nice, I'll have some design change proposals later, I already have this ones:

  • Reduce size of favicon (they seems blurry, I think default size is 16px)
  • Align title first line with the favicon itself
  • Add the domain name (like youtube.com) just under the title
  • Reduce the title size (I think the same size as the description is ok, bold should be enough to differentiate title and description)
  • If not already done, of course make it clickable, on slack the title is in blue and is clikable if we want to follow they implmentaiton

@rezk2ll
Copy link
Member Author

rezk2ll commented Jun 6, 2022

updated:

demo-links-preview-.mp4

image
image

@rezk2ll rezk2ll requested a review from romanesko June 6, 2022 15:10
@RomaricMourgues RomaricMourgues changed the title 🌟 added link preview in the frontend 🌟 Added link preview in the frontend Jun 7, 2022
@RomaricMourgues
Copy link
Contributor

More change request:

  • Let's put the domain next to the favicon instead of the title.
  • Let's put the title aligned with the description
  • Add border radius to the bottom on the link too

172189022-32a1cfbf-f072-4fd9-b9e1-1de818479b9c

@RomaricMourgues RomaricMourgues merged commit 917a8e4 into linagora:develop Jun 7, 2022
@RomaricMourgues RomaricMourgues added the qa:ready When a PR is ready to go to QA label Jun 7, 2022
RomaricMourgues pushed a commit that referenced this pull request Jun 7, 2022
* 🌟 added link preview in the frontend

* 🛠 handle parsed images being objects instead of urls

* 🛠 fixed links detection in message

* 🛠 fixed domain having www and added url to the preview

* 🛠 adjusted preview card style

* 🛠 updated unit tests

* 🛠 improved link preview display

* 🛠 fixed favicon alignment

* show link previews alongside files
@github-actions github-actions bot removed qa:ready When a PR is ready to go to QA staging:develop labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinksPreview::Links thumbnail frontend implementation
3 participants