-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SearchSnippet] SearchSnippet/get method #5254
Comments
I understand this ticket is implemented according to the jmap spec, but I have a related concern. The SearchSnippet object has only property:
I think it is not enough for FE, single jmap request:
If the frontend uses Is it no problem? CC: @hoangdat |
I get the concern but I don't think we should go out bonds of the RFC spec either. Not all properties that the front is using for email/get during a search is being shown on the screen btw, that could probably be optimized |
Notes: Change in SearchSnippet internal jmap doc Not implemented to Implemented |
Hi, from my understanding, FE can combine
And combine the response of get and searchsnippet to show to FE. No problem. |
The preview in SearchSnipet is not the preview of the message (as in email/get), but a subset of the relevant part of the body. Overall agrees. |
IMO, It will take us more time to combine it. Is there a better solution? I see |
The RFC says that it might not be responded in the same order as given in the request, I am unsure how complex it would be but I guess we could try? |
Like between email/query + email/get. Front should ensure the odering displayed is the one of email/query |
WIP apache#2442 |
I forgot this ticket isn't a priority in this sprint, so I'll pause it for now. |
Split tasks
And this ticket will focus on implement SearchSnippet/get for distributed |
Implement a new JMAP method as defined in https://jmap.io/spec-mail.html#search-snippets
Add a SearchSnippet object as defined per the RFC and implement the SearchSnippetGetMethod, that is similar to EmailQueryMethod, except that it would call the search with the highlight instead of normal search function.
Notes: Change in SearchSnippet internal jmap doc Not implemented to Implemented
DoD: Integration tests
The text was updated successfully, but these errors were encountered: