You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @slinderman, there's a tiny bug in the permute function of the _OrthogonalLinearEmissions class on line 268 of emissions.py:
self._Ms = self._Bs[perm]
should be
self._Ms = self._Ms[perm]
This is obviously an easy fix; do you have preferred way for me to address small bugs like this in the future? (i.e. through a pull request? I've never done those before)
The text was updated successfully, but these errors were encountered:
I'm going to work on a "Contributors Guide" with instructions on how to do that. I think the Github preferred way is via a PR, but that involves making a fork, editing it, and submitting a PR. I think you can do all of this via the web, but it is a bit roundabout. Stay tuned for more instructions on that, but in the meantime this is fine.
Hey @slinderman, there's a tiny bug in the
permute
function of the_OrthogonalLinearEmissions
class on line 268 ofemissions.py
:should be
This is obviously an easy fix; do you have preferred way for me to address small bugs like this in the future? (i.e. through a pull request? I've never done those before)
The text was updated successfully, but these errors were encountered: