Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bug in emissions.py #53

Closed
themattinthehatt opened this issue Jul 31, 2019 · 3 comments
Closed

small bug in emissions.py #53

themattinthehatt opened this issue Jul 31, 2019 · 3 comments

Comments

@themattinthehatt
Copy link
Collaborator

Hey @slinderman, there's a tiny bug in the permute function of the _OrthogonalLinearEmissions class on line 268 of emissions.py:

self._Ms = self._Bs[perm]

should be

self._Ms = self._Ms[perm]

This is obviously an easy fix; do you have preferred way for me to address small bugs like this in the future? (i.e. through a pull request? I've never done those before)

@slinderman
Copy link
Collaborator

Thanks Matt! Fixed here 0150fc4

I'm going to work on a "Contributors Guide" with instructions on how to do that. I think the Github preferred way is via a PR, but that involves making a fork, editing it, and submitting a PR. I think you can do all of this via the web, but it is a bit roundabout. Stay tuned for more instructions on that, but in the meantime this is fine.

@slinderman
Copy link
Collaborator

FYI: Check out this approach for making little changes like this one: https://help.github.com/en/articles/editing-files-in-another-users-repository

@themattinthehatt
Copy link
Collaborator Author

oh yes, that's super straightforward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants