Replies: 6 comments 2 replies
-
The default
I think this is a miss from our implementation - we probably want to also ignore this case by default.
Would handling the bug above be good enough? Or is this a separate issue? |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately for now, I don't think there's a way for users to customize which exceptions to ignore. It is possible to disable the exceptions reporter entirely until we make a fix 😅 . armeria/core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java Lines 2087 to 2101 in 5e79a26 |
Beta Was this translation helpful? Give feedback.
-
This is a different request. We have our own code that performs error handling. It looks somewhat like the following: This didn't work for ContentTooLargeException. So we had to change it to look like this: I think it would be nice to avoid having this special case. Also, are there other situations we may have missed where what we'd expect to be a status code exception do not come as an Thank you for your responses. |
Beta Was this translation helpful? Give feedback.
-
Are you performing error handling from e.g. Server.builder().errorHandler(new ServerErrorHandler() {
@Override
@Nullable
public HttpResponse onServiceException(ServiceRequestContext ctx, Throwable cause) {
if (cause instanceof MyException) {
return HttpResponse.of("my custom response");
}
// fallback to armeria's default error handling
return null;
}
});
The following is a list of error handling armeria does by default:
I see. I assume the If the above |
Beta Was this translation helpful? Give feedback.
-
I forgot to ask, but did you try adding a The original motivation for the If you aren't interested in seeing these logs, I think just ignoring them is fine (via setting |
Beta Was this translation helpful? Give feedback.
-
It sounds like a good idea. Created #5578 |
Beta Was this translation helpful? Give feedback.
-
|
@jrhee17 ,
No, we are doing this using a custom You can see the full context here: We also had it coming from a decorator. We were able to work-around that by adding a specific conditional. Making
No, I think we are using the default. I also think this is a useful feature to get these logs. Thanks for explaining how they work. We want to remove the logs by handling them correctly. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, @dlvenable If you just want not to see the logs, how about just using |
Beta Was this translation helpful? Give feedback.
-
I have observed the following behavior when clients send a request that exceeds the maximum size.
ContentTooLargeExceptionI have a few questions:
ExceptionHandlerFunction. Should we?ContentTooLargeExceptiondoes not inherit fromHttpStatusException. We currently have a block of code that handlesHttpStatusExceptionexceptions by looking to see if it is a client or server error. Can we makeContentTooLargeExceptioninherit fromHttpStatusException?Beta Was this translation helpful? Give feedback.
All reactions